mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Dale Amon <amon@vnl.com>
Cc: linux-kernel@vger.kernel.org, James.Bottomley@HansenPartnership.com
Subject: Re: 2.5.26 : drivers/scsi/BusLogic.c
Date: Thu, 18 Jul 2002 12:00:02 -0500	[thread overview]
Message-ID: <200207181700.g6IH03U02415@localhost.localdomain> (raw)

> BusLogic.c:32: #error Please convert me to Documentation/
> DMA-mapping.txt BusLogic.c: In function `BusLogic_DetectHostAdapter':
> BusLogic.c:2841: warning: long unsigned int format,
> BusLogic_IO_Address_T arg (arg 2) BusLogic.c: In function
> `BusLogic_QueueCommand': BusLogic.c:3415: structure has no member
> named `address' BusLogic.c: In function `BusLogic_BIOSDiskParameters':
> BusLogic.c:4141: warning: implicit declaration of function
> `scsi_bios_ptable' BusLogic.c:4141: warning: assignment makes pointer
> from integer without a cast make[2]: *** [BusLogic.o] Error 1

I have a single MCA Buslogic card on my shelf.  Assuming it hasn't got bitrot, 
I may be able to look at this soon.

In the meantime, if you want to try, the trick looks to be to use 
pci_map_single in BusLogic_CreateInitialCCBs; but then set up a reverse 
mapping table for them in BusLogic_InitializeCCBs so that Bus_to_Virtual will 
still work (its only use is to convert bus physical CCB addresses into CPU 
virtual ones).

Next, in BusLogic_QueueCommand you need to use pci_map_single for non-sg 
transformations, and pci_map_sg for sg plus in the loop over segments, use the 
macros

sg_dma_address(&ScatterList[Segment]) in place of ScatterList[Segment].address
sg_dma_len(&ScatterList[Segment]) in place ofScatterList[Segment].length

Initially, don't worry about unmapping, but this should get the thing working.

There are probably other places in the driver I've missed (like sense 
buffers), but that should be the core of the necessary changes.

I'm off on holiday for 10 days, so I'll only be getting email sporadically, if 
at all.

James



             reply	other threads:[~2002-07-18 16:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-18 17:00 James Bottomley [this message]
2002-07-18 23:24 ` Doug Ledford
2002-07-19 14:30   ` stoffel
2002-07-20 15:14   ` Dale Amon
2002-07-25 14:32   ` Dale Amon
  -- strict thread matches above, loose matches on Subject: below --
2002-07-18 15:45 Dale Amon
2002-07-18 16:16 ` Zwane Mwaikambo
2002-07-19  1:03   ` Doug Ledford
2002-07-19  1:19     ` Doug Ledford
2002-07-19  7:18       ` Michael G. Janicki
2002-07-19  8:41     ` Zwane Mwaikambo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200207181700.g6IH03U02415@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=amon@vnl.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®