mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stelian Pop <stelian.pop@fr.alcove.com>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: input subsystem config ?
Date: Fri, 19 Jul 2002 16:36:02 +0200	[thread overview]
Message-ID: <20020719143602.GH6490@tahoe.alcove-fr> (raw)
In-Reply-To: <20020718173132.A30621@ucw.cz>

On Thu, Jul 18, 2002 at 05:31:32PM +0200, Vojtech Pavlik wrote:

> > > Ok, that's what I wanted to know - I was wondering whether the mouse
> > > would simply ignore all control commands. And it doesn't not. It needs
> > > the commands, 
[...]

Ok, I've finally found out what's happenning: in i8042_aux_write()
you restore the CTR value each time. For some obscure reasons, my
laptop's controller does not like this at all. Disabling this
section makes the mouse function perfectly.

Is this CTR restore command really needed ? If it is, we should
probably add an option like "i8042_noctrrestore=1" to the i8042
driver...

Or maybe you have a better idea...

Stelian.

===== drivers/input/serio/i8042.c 1.5 vs edited =====
--- 1.5/drivers/input/serio/i8042.c	Sat Jul 13 20:31:00 2002
+++ edited/drivers/input/serio/i8042.c	Fri Jul 19 15:36:09 2002
@@ -221,12 +221,16 @@
 
 	retval  = i8042_command(&c, I8042_CMD_AUX_SEND);
 
+#if 0
 /*
  * Here we restore the CTR value. I don't know why, but i8042's in half-AT
  * mode tend to trash their CTR when doing the AUX_SEND command.
+ *
+ * However, for some reasons this breaks (at least) my Sony VAIO C1VE
+ * aux interface.
  */
-
 	retval |= i8042_command(&i8042_ctr, I8042_CMD_CTL_WCTR);
+#endif
 
 /*
  * Make sure the interrupt happens and the character is received even
-- 
Stelian Pop <stelian.pop@fr.alcove.com>
Alcove - http://www.alcove.com

  parent reply	other threads:[~2002-07-19 14:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-16 14:34 Stelian Pop
2002-07-17  9:56 ` Stelian Pop
2002-07-17 10:01   ` Vojtech Pavlik
2002-07-17 10:10     ` Stelian Pop
2002-07-17 12:08       ` Vojtech Pavlik
2002-07-17 13:24         ` Stelian Pop
2002-07-17 13:44           ` Vojtech Pavlik
2002-07-17 13:58             ` Stelian Pop
2002-07-17 14:29               ` Vojtech Pavlik
2002-07-17 14:55                 ` Stelian Pop
2002-07-17 15:22                   ` Vojtech Pavlik
2002-07-17 15:33                     ` Stelian Pop
2002-07-18 14:41                       ` Stelian Pop
2002-07-18 14:45                         ` Vojtech Pavlik
2002-07-18 14:48                           ` Stelian Pop
2002-07-18 15:15                             ` Vojtech Pavlik
2002-07-18 15:28                               ` Stelian Pop
2002-07-18 15:31                                 ` Vojtech Pavlik
2002-07-18 16:02                                   ` Stelian Pop
2002-07-19 14:36                                   ` Stelian Pop [this message]
2002-07-19 19:32                                     ` Vojtech Pavlik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020719143602.GH6490@tahoe.alcove-fr \
    --to=stelian.pop@fr.alcove.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®