From: "Adam J. Richter" <adam@yggdrasil.com>
To: rmk@arm.linux.org.uk, viro@math.psu.edu
Cc: andrea@suse.de, linux-kernel@vger.kernel.org
Subject: Re: Patch?: initial ramdisks did not work in 2.5.28-29
Date: Sun, 28 Jul 2002 17:17:07 -0700 [thread overview]
Message-ID: <200207290017.RAA00259@baldur.yggdrasil.com> (raw)
On Mon, 29 Jul 2002 00:51:56 +0100, Russell King wrote:
>On Sun, Jul 28, 2002 at 04:42:20PM -0700, Adam J. Richter wrote:
>> Initial ramdisks do not work in linux-2.5.2{8,9}, because
>Correct.
[...]
>Al has been working on the problem. To permanently fix it so it doesn't
>break each time a change to do_open() happens.
[...]
>My temporary hack around the problem was to use rd_length[unit] since
>that's already in bytes.
[...]
Thanks for the quick response. Your solution is simpler.
Although some bigger change may be in the works, would anyone
object to my submitting the following patch (your version of the fix)
to Linus in the meantime? I am cc'ing this message to Al Viro.
Adam J. Richter __ ______________ 575 Oroville Road
adam@yggdrasil.com \ / Milpitas, California 95035
+1 408 309-6081 | g g d r a s i l United States of America
"Free Software For The Rest Of Us."
--- linux-2.5.29/drivers/block/rd.c 2002-07-26 19:58:39.000000000 -0700
+++ linux/drivers/block/rd.c 2002-07-28 16:59:05.000000000 -0700
@@ -379,6 +404,7 @@
rd_bdev[unit]->bd_openers++;
rd_bdev[unit]->bd_block_size = rd_blocksize;
rd_bdev[unit]->bd_inode->i_mapping->a_ops = &ramdisk_aops;
+ rd_bdev[unit]->bd_inode->i_size = rd_length[unit];
rd_bdev[unit]->bd_queue = &blk_dev[MAJOR_NR].request_queue;
}
next reply other threads:[~2002-07-29 0:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-29 0:17 Adam J. Richter [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-07-28 23:42 Adam J. Richter
2002-07-28 23:51 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200207290017.RAA00259@baldur.yggdrasil.com \
--to=adam@yggdrasil.com \
--cc=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®