From: Muli Ben-Yehuda <mulix@actcom.co.il>
To: Zwane Mwaikambo <zwane@linuxpower.ca>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.5.29 sound/oss/trident.c [2/2] remove cli/sti calls
Date: Mon, 29 Jul 2002 11:08:37 +0300 [thread overview]
Message-ID: <20020729080836.GO10499@alhambra.actcom.co.il> (raw)
In-Reply-To: <Pine.LNX.4.44.0207290948110.20701-100000@linux-box.realnet.co.sz>
[-- Attachment #1: Type: text/plain, Size: 763 bytes --]
On Mon, Jul 29, 2002 at 10:08:52AM +0200, Zwane Mwaikambo wrote:
> On Sun, 28 Jul 2002, Muli Ben-Yehuda wrote:
>
> > +
> > + spin_unlock_irqrestore(&card->lock, flags);
> >
> > restore_flags(flags);
> > }
>
> hmm...
grrr, harmless I think, but thanks for spotting it.
===== sound/oss/trident.c 1.25 vs 1.26 =====
--- 1.25/sound/oss/trident.c Mon Jul 29 07:08:09 2002
+++ 1.26/sound/oss/trident.c Mon Jul 29 10:59:59 2002
@@ -3563,8 +3563,6 @@
outl(ali_registers.global_regs[0x2c], TRID_REG(card,T4D_MISCINT));
spin_unlock_irqrestore(&card->lock, flags);
-
- restore_flags(flags);
}
static int trident_suspend(struct pci_dev *dev, u32 unused)
--
http://vipe.technion.ac.il/~mulix/
http://syscalltrack.sf.net/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2002-07-29 8:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-28 20:22 Muli Ben-Yehuda
2002-07-29 8:08 ` Zwane Mwaikambo
2002-07-29 8:08 ` Muli Ben-Yehuda [this message]
2002-07-29 8:56 ` Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020729080836.GO10499@alhambra.actcom.co.il \
--to=mulix@actcom.co.il \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®