From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Ingo Molnar <mingo@elte.hu>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org, arjanv@redhat.com
Subject: Re: [patch] APM fixes, 2.5.29
Date: Mon, 29 Jul 2002 13:05:56 +1000 [thread overview]
Message-ID: <20020729130556.48e6d27d.sfr@canb.auug.org.au> (raw)
In-Reply-To: <Pine.LNX.4.44.0207281326150.21244-100000@localhost.localdomain>
Hi Ingo,
On Sun, 28 Jul 2002 13:28:34 +0200 (CEST) Ingo Molnar <mingo@elte.hu> wrote:
>
>
> the attached patch fixes two things:
>
> - a TLS related bug noticed by Arjan van de Ven: apm_init() should set up
> all CPU's gdt entries - just in case some code happens to call in the
> APM BIOS on the wrong CPU. This should also handle the case when some
> APM code gets triggered (by suspend or power button or something).
Except, if you read the comment, we never do APM BIOS calls on anything
but CPU 0. On SMP the only APM BIOS operation we allow is power off
and we have code to ensure we are on CPU 0 before we do that ...
> - compilation problem
I would prefer a patch (see the post by Muli Ben-Yehuda
<mulix@actcom.co.il>) that defines num_possible_cpus() or equivalent, the
current code (using num_online_cpus()) is broken in places.
I need to revisit all this code in light of CPU hotplug ...
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
next prev parent reply other threads:[~2002-07-29 3:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-28 9:54 [patch] sched-2.5.29-B1 Ingo Molnar
2002-07-28 11:28 ` [patch] APM fixes, 2.5.29 Ingo Molnar
2002-07-29 3:05 ` Stephen Rothwell [this message]
2002-07-29 11:51 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020729130556.48e6d27d.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=arjanv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®