From: James Bottomley <James.Bottomley@steeleye.com>
To: Jens Axboe <axboe@suse.de>
Cc: Linus Torvalds <torvalds@transmeta.com>,
James Bottomley <James.Bottomley@SteelEye.com>,
Marcin Dalecki <dalecki@evision.ag>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.28 small REQ_SPECIAL abstraction
Date: Mon, 29 Jul 2002 08:44:12 -0500 [thread overview]
Message-ID: <200207291344.g6TDiCR11064@localhost.localdomain> (raw)
In-Reply-To: Message from Jens Axboe <axboe@suse.de> of "Mon, 29 Jul 2002 12:43:51 +0200." <20020729124351.C4861@suse.de>
axboe@suse.de said:
> Ok... I had two issues with the patch. 1) it did
> rq->flags &= REQ_QUEUED;
Yes, that was inherited from SCSI. Previously it just cleared flags and then
set REQ_BARRIER|REQ_SPECIAL. Now I needed to clear flags but preserve the
state of REQ_QUEUED, which is what that code is doing, otherwise the
blk_rq_tagged() would always fail lower down.
> I'll back down, it's not a matter of life and death after all. Here's
> the minimal patch that corrects the flag thing, and also makes
> blk_insert_request() conform to kernel style. Are we all happy?
I'm happy (as long as it works on my SCSI card).
James
next prev parent reply other threads:[~2002-07-29 13:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-28 20:13 James Bottomley
2002-07-29 5:37 ` Jens Axboe
2002-07-29 5:55 ` Jens Axboe
2002-07-29 6:23 ` Linus Torvalds
2002-07-29 6:34 ` Jens Axboe
2002-07-29 6:58 ` Linus Torvalds
2002-07-29 10:43 ` Jens Axboe
2002-07-29 13:44 ` James Bottomley [this message]
2002-07-29 13:50 ` Marcin Dalecki
-- strict thread matches above, loose matches on Subject: below --
2002-07-28 23:59 Andries.Brouwer
2002-07-29 0:33 ` Linus Torvalds
2002-07-29 0:52 ` Dave Jones
2002-07-30 0:50 ` Rob Landley
2002-07-24 21:13 Linux-2.5.28 Linus Torvalds
2002-07-26 6:03 ` [PATCH] 2.5.28 small REQ_SPECIAL abstraction Marcin Dalecki
2002-07-26 14:38 ` Jens Axboe
2002-07-26 15:09 ` Marcin Dalecki
2002-07-28 19:25 ` Jens Axboe
2002-07-28 23:32 ` Linus Torvalds
2002-07-29 5:39 ` Jens Axboe
2002-07-29 5:50 ` Linus Torvalds
2002-07-29 10:24 ` Marcin Dalecki
2002-07-29 10:44 ` Jens Axboe
2002-07-29 11:05 ` Marcin Dalecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200207291344.g6TDiCR11064@localhost.localdomain \
--to=james.bottomley@steeleye.com \
--cc=axboe@suse.de \
--cc=dalecki@evision.ag \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®