From: Andi Kleen <ak@suse.de>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Muli Ben-Yehuda <mulix@actcom.co.il>,
ak@suse.de, linux-kernel@vger.kernel.org
Subject: Re: rename 'unused' in sys_iopl to somethign else, since it is used
Date: Tue, 30 Jul 2002 06:25:52 +0200 [thread overview]
Message-ID: <20020730062552.A922@wotan.suse.de> (raw)
In-Reply-To: <20020730011859.96E0B4276@lists.samba.org>
On Tue, Jul 30, 2002 at 11:02:33AM +1000, Rusty Russell wrote:
> In message <20020728141256.GA9573@alhambra.actcom.co.il> you write:
> > sys_iopl on i386 accepts one parameter, 'unsigned long unused'. Then
> > it goes ahead and uses it to get a pointer to struct pt_regs. This
> > patch changes its name to 'location'.=20
>
> Hmmm.... Andi, the x86_64 version is different: do you really push one
> arg on the stack then the regs? Please check...
level is in a register (rdi), but pt_regs is on the stack. The calling
convention automatically switches to stack location for structures bigger
than one register.
On i386 it is probably cleanest when you need both pt_regs and arguments
to declare pt_regs only and get the first argument directly out of regs->ebx.
-Andi
prev parent reply other threads:[~2002-07-30 4:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20020728141256.GA9573@alhambra.actcom.co.il>
2002-07-30 1:02 ` Rusty Russell
2002-07-30 4:25 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020730062552.A922@wotan.suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mulix@actcom.co.il \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®