Re: [PATCH] eepro 0.13a

[Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org>]

> > @@ -633,37 +633,37 @@
> >  
> >  	i = inb(dev->base_addr + ID_REG);
> >  	printk(KERN_DEBUG " id: %#x ",i);
> > -	printk(KERN_DEBUG " io: %#x ", (unsigned)dev->base_addr);
> > +	printk(" io: %#x ", (unsigned)dev->base_addr);
> >  
> >  	switch (lp->eepro) {
> >  		case LAN595FX_10ISA:
> > -			printk(KERN_INFO "%s: Intel EtherExpress 10 ISA\n at %#x,",
> > +			printk("%s: Intel EtherExpress 10 ISA\n at %#x,",
> >  					dev->name, (unsigned)dev->base_addr);
> 
> [more cases deleted]
> 
> This surely can't be right. Why are you dropping all the KERN_*s ?
printk that doesn't start a new line had KERN_* removed because it prints in
the middle of line KERN_* macros like
 id: 0xb4 <7> io: 0x340 <6>eth0: Intel EtherExpress Pro/10+ ISA
i had the same reaction but Michael pointed this to me. i don't know exactly
how this macro works, but you'll have the line printed out with the
beggining using KERN_* macro. isn't that sufficient?

-- 
aris