mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@steeleye.com>
To: suparna@in.ibm.com
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	axboe@kernel.org, B.Zolnierkiewicz@elka.pw.edu.pl,
	akpm@zip.com.au
Subject: Re: [PATCH] Bio Traversal Changes
Date: Fri, 02 Aug 2002 08:48:06 -0500	[thread overview]
Message-ID: <200208021348.g72Dm7q03058@localhost.localdomain> (raw)
In-Reply-To: Message from Suparna Bhattacharya <suparna@in.ibm.com>  of "Fri, 02 Aug 2002 18:05:13 +0530." <20020802180513.A1802@in.ibm.com>

The SCSI changes (small that they are) look reasonable.

This does look like it exposes an existing problem in the tag/barrier 
approach, though.

The bio can be split by making multiple requests over segements of the bio, 
correct?  If this is a BIO_RW_BARRIER, then each of these requests will be a 
REQ_BARRIER.  However, in the SCSI paradigm where we translate REQ_BARRIER to 
ordered tag, each of the requests will get a new ordered tag as it comes back 
around through end_that_request_first, potentially allowing other tags to be 
inserted in between these, which would be incorrect, since other bios would be 
inserted in between the segments of this one, thus violating the barrier.

Is the above correct?  If it is, I may have finally found a use for linked 
scsi tasks (gives you the ability to have one tag cover multiple commands).

James



  parent reply	other threads:[~2002-08-02 13:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-02 12:35 Suparna Bhattacharya
2002-08-02 12:43 ` [PATCH] Bio Traversal Changes (Patch 1/4: biotr8-blk.diff) Suparna Bhattacharya
2002-08-02 12:46 ` [PATCH] Bio Traversal Changes (Patch 2/4: biotr8-blkusers.diff) Suparna Bhattacharya
2002-08-02 13:17 ` [PATCH] Bio Traversal Changes - (Patch 3/4 : biotr8-blkdrivers.diff) Suparna Bhattacharya
2002-08-02 13:20 ` [PATCH] Bio Traversal Changes (Patch 4/4: biotr8-doc.diff) Suparna Bhattacharya
2002-08-02 13:48 ` James Bottomley [this message]
2002-08-05 12:38   ` [PATCH] Bio Traversal Changes Suparna Bhattacharya
2002-08-05 15:47     ` James Bottomley
2002-08-06 12:17       ` Suparna Bhattacharya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200208021348.g72Dm7q03058@localhost.localdomain \
    --to=james.bottomley@steeleye.com \
    --cc=B.Zolnierkiewicz@elka.pw.edu.pl \
    --cc=akpm@zip.com.au \
    --cc=axboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=suparna@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®