From: Matthew Wilcox <willy@debian.org>
To: gerg@snapgear.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: linux-2.5.30uc0 MMU-less patches
Date: Fri, 2 Aug 2002 14:50:34 +0100 [thread overview]
Message-ID: <20020802145034.B24631@parcelfarce.linux.theplanet.co.uk> (raw)
Some constructive criticism...
- the Makefile changes seem terribly inappropriate.
- you probably didn't mean to include page_alloc2.hack in the diff
- Do you really need your own copy of fbcon.c? Can it be merged with the
one in drivers/video?
- arch/m68knommu/console/68328fb.c should probably move to drivers/video
too.
- ditto most of the other files in the console directory ...
- Why are the changes to rd.c required?
- I'm not sure it's appropriate to include the changes to nfs2xdr.c --
is this a toolchain bug you're working around?
- drivers/char/mcfserial.c needs to be converted to the new serial core
and moved to drivers/serial.
- ditto arch/m68knommu/platform/68360/quicc/uart.c
I'll look at the change you want to make to locks.c - I'm not terribly
fond of that interaction either.
--
Revolutions do not require corporate support.
next reply other threads:[~2002-08-02 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-02 13:50 Matthew Wilcox [this message]
2002-08-02 15:51 ` gerg
2002-08-02 16:00 ` Russell King
2002-08-02 16:14 ` gerg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020802145034.B24631@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=gerg@snapgear.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®