From: "Adam J. Richter" <adam@yggdrasil.com>
To: rmk@arm.linux.org.uk
Cc: axel@hh59.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, tytso@mit.edu
Subject: Re: Linux 2.5.30: [SERIAL] build fails at 8250.c
Date: Fri, 2 Aug 2002 17:20:28 -0700 [thread overview]
Message-ID: <200208030020.RAA05695@baldur.yggdrasil.com> (raw)
On Sat, 3 Aug 2002 01:12:10 +0100, Russell King wrote:
>Ok, here's a fix for the 8250.c build problem (please don't send it
>to Linus; I've other changes that'll be going via BK and patch to
>lkml pending):
>
>--- orig/drivers/serial/8250.c Fri Aug 2 21:13:31 2002
>+++ linux/drivers/serial/8250.c Sat Aug 3 00:28:47 2002
>@@ -31,7 +31,8 @@
> #include <linux/console.h>
> #include <linux/sysrq.h>
> #include <linux/serial_reg.h>
>-#include <linux/serialP.h>
>+#include <linux/circ_buf.h>
>+#include <linux/serial.h>
> #include <linux/delay.h>
>
> #include <asm/io.h>
Your patch still results in a compilation error for me.
It looks like 8250.c needs <linux/serialP.h> for ALPHA_KLUDGE_MCR:
gcc -Wp,-MD,./.8250.o.d -D__KERNEL__ -I/usr/src/linux/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i386 -nostdinc -iwithprefix include -DMODULE -include /usr/src/linux/include/linux/modversions.h -DKBUILD_BASENAME=8250 -DEXPORT_SYMTAB -c -o 8250.o 8250.c
8250.c: In function `serial8250_set_mctrl':
8250.c:1061: `ALPHA_KLUDGE_MCR' undeclared (first use in this function)
8250.c:1061: (Each undeclared identifier is reported only once
8250.c:1061: for each function it appears in.)
Adam J. Richter __ ______________ 575 Oroville Road
adam@yggdrasil.com \ / Milpitas, California 95035
+1 408 309-6081 | g g d r a s i l United States of America
"Free Software For The Rest Of Us."
next reply other threads:[~2002-08-03 0:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-03 0:20 Adam J. Richter [this message]
2002-08-03 8:05 ` Russell King
-- strict thread matches above, loose matches on Subject: below --
2002-08-03 8:42 Adam J. Richter
2002-08-02 22:49 Adam J. Richter
2002-08-02 23:56 ` Russell King
2002-08-03 0:12 ` Russell King
2002-08-03 1:05 ` Kai Germaschewski
2002-08-01 21:30 Linux 2.5.30 Linus Torvalds
2002-08-02 1:25 ` Linux 2.5.30: [SERIAL] build fails at 8250.c Axel Siebenwirth
2002-08-02 17:13 ` Russell King
2002-08-02 19:19 ` Axel Siebenwirth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200208030020.RAA05695@baldur.yggdrasil.com \
--to=adam@yggdrasil.com \
--cc=axel@hh59.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®