mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Linus Torvalds <torvalds@transmeta.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 10: 2.5.29-wdt977
Date: Sat, 3 Aug 2002 22:50:53 +0200	[thread overview]
Message-ID: <20020803225053.A1515@mars.ravnborg.org> (raw)
In-Reply-To: <E17b3Rq-0006wh-00@flint.arm.linux.org.uk>; from rmk@arm.linux.org.uk on Sat, Aug 03, 2002 at 07:16:18PM +0100

On Sat, Aug 03, 2002 at 07:16:18PM +0100, Russell King wrote:
> Bitops are used with on the timer_alive variable.  Therefore, timer_alive
> needs to be "unsigned long" not "int".

How about:
> -static	int timer_alive;
> +static	bitmap_member(timer_alive, 1);

In this way it is obviously used for bitops.

Rusty's more informative DECLARE_BITMAP (IIRC) patch has not yet been 
accepted by Linus, otherwise it would better tell people that this is 
actually a macro without the need to parse the declaration first.

	Sam


      parent reply	other threads:[~2002-08-04 11:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-03 18:16 Russell King
2002-08-03 17:49 ` Rob Radez
2002-08-03 20:50 ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020803225053.A1515@mars.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®