From: Petr Vandrovec <vandrove@vc.cvut.cz>
To: martin@dalecki.de
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] IDE udma_status = 0x76 and 2.5.30...
Date: Mon, 5 Aug 2002 00:25:42 +0200 [thread overview]
Message-ID: <20020804222542.GH13053@ppc.vc.cvut.cz> (raw)
Hi,
patch below fixes troubles with PDC20265 reporting udma_status = 0x76
with kernels since pcidma cleanup (it was already reported here, but
I did not found patch for it). Code before change (IDE110) set highest
bit of last dword to 1 on all devices except TRM290. New code
set it only on TRM290 devices, which breaks at least mine PDC20265.
Please send it to Linus in your next update.
BTW, are there any TRM290 owners using 2.5.30? Old code set length to
((length >> 2) - 1) << 16, while new code does not have special handling
for TRM290. Or do I miss something?
And BTW#2, mine problematic Toshiba disk works fine with PDC20265 with
512B request size... It breaks with i845 and i440BX, under any UDMA.
Thanks,
Petr Vandrovec
vandrove@vc.cvut.cz
diff -urdN linux/drivers/ide/pcidma.c linux/drivers/ide/pcidma.c
--- linux/drivers/ide/pcidma.c 2002-08-04 17:54:41.000000000 +0200
+++ linux/drivers/ide/pcidma.c 2002-08-04 23:52:33.000000000 +0200
@@ -403,10 +403,8 @@
sg++;
}
-#ifdef CONFIG_BLK_DEV_TRM290
- if (ch->chipset == ide_trm290)
+ if (ch->chipset != ide_trm290)
*--table |= cpu_to_le32(0x80000000);
-#endif
return ch->sg_nents;
}
next reply other threads:[~2002-08-04 22:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-04 22:25 Petr Vandrovec [this message]
2002-08-05 9:33 ` Marcin Dalecki
2002-08-05 20:08 ` Andre Hedrick
2002-08-05 21:42 ` Alan Cox
2002-08-05 10:18 Petr Vandrovec
2002-08-05 10:28 ` Marcin Dalecki
2002-08-05 14:07 Petr Vandrovec
2002-08-05 14:21 ` Marcin Dalecki
2002-08-05 20:31 Petr Vandrovec
2002-08-05 21:10 ` Andre Hedrick
2002-08-05 21:19 ` Andre Hedrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020804222542.GH13053@ppc.vc.cvut.cz \
--to=vandrove@vc.cvut.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@dalecki.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®