Re: [PATCH] conditionally re-enable per-disk stats, convert to seq_file

[Andries Brouwer <aebr@win.tue.nl>]

> On Tue, Aug 06, 2002 at 04:08:48PM +0200, Christoph Hellwig wrote:
> > This patch against 2.4.20-pre1 converts /proc/partitions to the seq_file
> > interface as in 2.5, makes it report the sard-style extended disk
> > statistics condititional on CONFIG_BLK_STATS and disables the gathering
> > of those totally otherwise to not waste memory and processing power.

But why in /proc/partitions ?
Maybe /proc/partitions can go away eventually with all info available
under driverfs or so. But for the time being, /proc/partitions is used,
and some changes are planned to make identification of the devices
involved easier.
It is really ugly to stuff a lot of garbage into a file just because
it happens to exist already. If you want disk statistics, why not
put it in /proc/diskstatistics?

Andries