From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Grant Grundler <grundler@dsl2.external.hp.com>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Jeff Garzik <jgarzik@mandrakesoft.com>,
"David S. Miller" <davem@redhat.com>
Subject: Re: PCI<->PCI bridges, transparent resource fix
Date: Fri, 9 Aug 2002 21:16:52 +0400 [thread overview]
Message-ID: <20020809211652.B17979@jurassic.park.msu.ru> (raw)
In-Reply-To: <20020809080630.13608@smtp.wanadoo.fr>; from benh@kernel.crashing.org on Fri, Aug 09, 2002 at 10:06:30AM +0200
On Fri, Aug 09, 2002 at 10:06:30AM +0200, Benjamin Herrenschmidt wrote:
> BTW, in the case of really closed resources, you just removed the "else"
> case. I don't have the kernel sources at hand at the moment (still
> on vacation ;) So I can't check how pci_dev is initialized on alloc,
It's zeroed.
> but shouldn't we make sure the resoure pointer of the child is either
> NULL or points to some properly zeroed out resource structure ?
I'm not sure whether it could happen in current 2.4/2.5 code, but
if pci_read_bridge_bases() is called from hotplug code, and
bridge's window changes from "enabled" to "disabled" (card removed),
then yes, we must set resource.flags = 0.
Ivan.
next prev parent reply other threads:[~2002-08-09 17:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20020806192951.7E6B44829@dsl2.external.hp.com>
2002-08-06 19:20 ` Benjamin Herrenschmidt
2002-08-07 5:54 ` Grant Grundler
2002-08-06 21:02 ` Benjamin Herrenschmidt
2002-08-07 18:30 ` Grant Grundler
2002-08-08 11:30 ` Ivan Kokshaysky
2002-08-09 7:07 ` Grant Grundler
2002-08-09 8:06 ` Benjamin Herrenschmidt
2002-08-09 17:16 ` Ivan Kokshaysky [this message]
[not found] <20020807042402.A4840@jurassic.park.msu.ru>
2002-08-06 20:31 ` Benjamin Herrenschmidt
2002-08-07 16:03 ` Ivan Kokshaysky
2002-08-08 8:20 ` Benjamin Herrenschmidt
2002-08-08 13:21 ` Ivan Kokshaysky
2002-08-09 6:29 ` Benjamin Herrenschmidt
2002-08-09 17:01 ` Ivan Kokshaysky
2002-08-09 21:14 ` Benjamin Herrenschmidt
2002-08-06 18:44 Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020809211652.B17979@jurassic.park.msu.ru \
--to=ink@jurassic.park.msu.ru \
--cc=benh@kernel.crashing.org \
--cc=davem@redhat.com \
--cc=grundler@dsl2.external.hp.com \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®