From: Phil Auld <pauld@egenera.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: viro@math.psu.edu, marcelo@connectiva.com.br,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.4.19 revert block_llseek behavior to standard
Date: Mon, 12 Aug 2002 12:36:32 -0400 [thread overview]
Message-ID: <20020812123632.E27650@vienna.EGENERA.COM> (raw)
In-Reply-To: <1029169257.16424.176.camel@irongate.swansea.linux.org.uk>; from alan@lxorguk.ukuu.org.uk on Mon, Aug 12, 2002 at 05:20:57PM +0100
Rumor has it that on Mon, Aug 12, 2002 at 05:20:57PM +0100 Alan Cox said:
> On Mon, 2002-08-12 at 17:06, Phil Auld wrote:
> > Hi Al,
> > I think this falls under the VFS umbrella, but I may be wrong.
> >
> > Below is a fix to make block_llseek behave as specified in the Single Unix Spec. v3.
> > (http://www.unix-systems.org/single_unix_specification/). It's extremely trivial but
> > may have political baggage.
>
> Political I don't see any. Technical - have you verified each of our
> block drivers behaves correctly when given an offset over its side, and
> that it correctly fails on a 32bit block wrap.
>
No, but how did it work prior to 2.4.11?
> I suspect we should still fail it with the allowed error code to be safe
> in 2.4
I may be missing something. How does tying a return of EINVAL to the size
necessarily imply the resulting offset will be negative? There is already
an explicit test for that.
--
Philip R. Auld, Ph.D. Technical Staff
Egenera Corp. pauld@egenera.com
165 Forest St., Marlboro, MA 01752 (508)858-2600
next prev parent reply other threads:[~2002-08-12 16:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-12 16:06 Phil Auld
2002-08-12 16:20 ` Alan Cox
2002-08-12 16:36 ` Phil Auld [this message]
2002-08-12 17:14 ` Alan Cox
2002-08-12 17:57 ` Phil Auld
2002-08-12 18:06 ` Alan Cox
2002-08-12 18:14 ` Phil Auld
2002-08-12 18:06 ` Phil Auld
2002-08-12 16:46 ` Christoph Hellwig
2002-08-12 17:14 ` Phil Auld
2002-08-13 8:13 ` Helge Hafting
[not found] <266483518@toto.iv>
2002-08-12 22:25 ` Peter Chubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020812123632.E27650@vienna.EGENERA.COM \
--to=pauld@egenera.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@connectiva.com.br \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®