mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oleg Drokin <green@namesys.com>
To: Christoph Hellwig <hch@infradead.org>,
	linux-kernel@vger.kernel.org, reiserfs-dev@namesys.com,
	viro@math.psu.edu
Subject: Re: Need more symbols to be exported out of kernel
Date: Mon, 19 Aug 2002 19:27:42 +0400	[thread overview]
Message-ID: <20020819192742.A19821@namesys.com> (raw)
In-Reply-To: <20020819155226.A26430@infradead.org>

Hello!

On Mon, Aug 19, 2002 at 03:52:26PM +0100, Christoph Hellwig wrote:

> >    remove_suid
> trivial inline,  either move it to a header or copy & paste.

Moving to header file trned out to be not that trivial ;)
So I just exported it as it is, since it never was inline desplite
the definition.
Ans I hate duplicating code as it will become maintenance nightmare
later.

Ok, here is first draft of the patch, any issues?

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
#	           ChangeSet	1.748   -> 1.749  
#	      kernel/ksyms.c	1.60    -> 1.61   
#	        mm/filemap.c	1.67    -> 1.68   
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 02/08/19	green@angband.namesys.com	1.749
# export generic_osync_inode,block_commit_write, remove_suid
# --------------------------------------------
#
diff -Nru a/kernel/ksyms.c b/kernel/ksyms.c
--- a/kernel/ksyms.c	Mon Aug 19 19:24:31 2002
+++ b/kernel/ksyms.c	Mon Aug 19 19:24:31 2002
@@ -215,6 +215,7 @@
 EXPORT_SYMBOL(generic_cont_expand);
 EXPORT_SYMBOL(cont_prepare_write);
 EXPORT_SYMBOL(generic_commit_write);
+EXPORT_SYMBOL(block_commit_write);
 EXPORT_SYMBOL(block_truncate_page);
 EXPORT_SYMBOL(generic_block_bmap);
 EXPORT_SYMBOL(generic_file_read);
@@ -531,6 +532,8 @@
 EXPORT_SYMBOL(is_bad_inode);
 EXPORT_SYMBOL(event);
 EXPORT_SYMBOL(brw_page);
+EXPORT_SYMBOL(generic_osync_inode);
+EXPORT_SYMBOL(remove_suid);
 
 #ifdef CONFIG_UID16
 EXPORT_SYMBOL(overflowuid);
diff -Nru a/mm/filemap.c b/mm/filemap.c
--- a/mm/filemap.c	Mon Aug 19 19:24:31 2002
+++ b/mm/filemap.c	Mon Aug 19 19:24:31 2002
@@ -2886,7 +2886,7 @@
 	return page;
 }
 
-inline void remove_suid(struct inode *inode)
+void remove_suid(struct inode *inode)
 {
 	unsigned int mode;
 

Bye,
    Oleg

      reply	other threads:[~2002-08-19 15:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-19 14:42 Oleg Drokin
2002-08-19 14:52 ` Christoph Hellwig
2002-08-19 15:27   ` Oleg Drokin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020819192742.A19821@namesys.com \
    --to=green@namesys.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=reiserfs-dev@namesys.com \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®