From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@zip.com.au>
Cc: Marcus Alanen <maalanen@ra.abo.fi>, linux-kernel@vger.kernel.org
Subject: Re: [patch, 2.5] vmalloc.c error path fixes
Date: Fri, 23 Aug 2002 20:11:33 +0100 [thread overview]
Message-ID: <20020823201133.A26160@infradead.org> (raw)
In-Reply-To: <3D628BF5.26FBE772@zip.com.au>; from akpm@zip.com.au on Tue, Aug 20, 2002 at 11:35:33AM -0700
On Tue, Aug 20, 2002 at 11:35:33AM -0700, Andrew Morton wrote:
> > of the diff fix a spinlock being held if an error occurs in
> > map_vm_area, and the last part fixes the error path of __vmalloc.
>
> Certainly agree on the first chunk. Listen to the old guy: "Thou
> shalt not have more than one return statement per function".
>
> Second chunk looks good too, but perhaps there's another way of doing
> it. The 2.5.31 code just tossed it all at vfree. Perhaps hch can
> comment?
The code looks fine - I missed that error checking. A little nitpick:
either remove the comment inn the last chunk as it's obvious what we
are doing or at least make it fit an ansi terminal.
prev parent reply other threads:[~2002-08-23 19:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-20 17:43 Marcus Alanen
2002-08-20 18:35 ` Andrew Morton
2002-08-23 19:11 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020823201133.A26160@infradead.org \
--to=hch@infradead.org \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=maalanen@ra.abo.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®