From: silvio@qualys.com
To: linux-kernel@vger.kernel.org
Subject: [PATCH] linux-2.4.19/drivers/ieee1394/video1394.c
Date: Sat, 24 Aug 2002 05:44:16 -0700 [thread overview]
Message-ID: <20020824054416.A3582@hamsec.aurora.sfo.interquest.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 156 bytes --]
avoid possible integer overflow
(also change the <= to just != since its using unsigned types anyway making
the sign test invalid here *shrug*)
--
Silvio
[-- Attachment #2: patch.video1394 --]
[-- Type: text/plain, Size: 610 bytes --]
--- linux-2.4.19/drivers/ieee1394/video1394.c Sat Aug 24 05:37:15 2002
+++ linux-2.4.19-dev/drivers/ieee1394/video1394.c Sat Aug 24 05:40:22 2002
@@ -871,13 +871,13 @@
}
ohci->ISO_channel_usage |= mask;
- if (v.buf_size<=0) {
+ if (v.buf_size == 0 || v.buf_size > VIDEO1394_MAX_SIZE) {
PRINT(KERN_ERR, ohci->id,
"Invalid %d length buffer requested",v.buf_size);
return -EFAULT;
}
- if (v.nb_buffers<=0) {
+ if (v.nb_buffers == 0 || v.nb_buffers > VIDEO1394_MAX_SIZE) {
PRINT(KERN_ERR, ohci->id,
"Invalid %d buffers requested",v.nb_buffers);
return -EFAULT;
reply other threads:[~2002-08-24 12:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020824054416.A3582@hamsec.aurora.sfo.interquest.net \
--to=silvio@qualys.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®