From: "Peter T. Breuer" <ptb@it.uc3m.es>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] apm cannot be compiled as a module in 2.5.31
Date: Sun, 25 Aug 2002 15:21:09 +0200 (MET DST) [thread overview]
Message-ID: <200208251321.g7PDL9v09118@oboe.it.uc3m.es> (raw)
apm complains about cpu_gdt_table and xtime_lock when compiled as a
module for SMP. Yes, it makes sense. I run the same kernel everywhere,
even on machines with one cpu.
--- kernel/ksyms.c.orig Sun Aug 25 15:15:02 2002
+++ kernel/ksyms.c Thu Aug 22 19:11:07 2002
@@ -428,6 +428,10 @@
EXPORT_SYMBOL(__br_write_unlock);
#endif
+#ifdef CONFIG_X86
+EXPORT_SYMBOL(cpu_gdt_table);
+#endif
+
/* Kiobufs */
EXPORT_SYMBOL(alloc_kiovec);
EXPORT_SYMBOL(free_kiovec);
Hurrr .. the xtime_lock is harder. Have to EXPORT from the file where
it is defined. Locks only make sense in SMP so only export if compiled
for SMP.
--- kernel/timer.c.orig Sun Aug 25 15:17:09 2002
+++ kernel/timer.c Thu Aug 22 19:13:15 2002
@@ -635,6 +635,9 @@
* playing with xtime and avenrun.
*/
rwlock_t xtime_lock __cacheline_aligned_in_smp = RW_LOCK_UNLOCKED;
+#ifdef CONFIG_SMP
+EXPORT_SYMBOL(xtime_lock);
+#endif
unsigned long last_time_offset;
And we need to fix the kernel/Makefile too?
--- kernel/Makefile.orig Sun Aug 25 15:19:22 2002
+++ kernel/Makefile Thu Aug 22 19:11:59 2002
@@ -10,7 +10,7 @@
O_TARGET := kernel.o
export-objs = signal.o sys.o kmod.o context.o ksyms.o pm.o exec_domain.o \
- printk.o platform.o suspend.o dma.o
+ printk.o platform.o suspend.o dma.o timer.o
obj-y = sched.o fork.o exec_domain.o panic.o printk.o \
module.o exit.o itimer.o time.o softirq.o resource.o \
next reply other threads:[~2002-08-25 13:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-25 13:21 Peter T. Breuer [this message]
2002-08-25 14:30 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200208251321.g7PDL9v09118@oboe.it.uc3m.es \
--to=ptb@it.uc3m.es \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®