From: Matthew Wilcox <willy@debian.org>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] (re)implement setkeycode/getkeycode/kd_mksound/kbd_setrate via the input core
Date: Sun, 25 Aug 2002 22:14:27 +0100 [thread overview]
Message-ID: <20020825221427.A6931@parcelfarce.linux.theplanet.co.uk> (raw)
This bit looks wrong to me:
+ for (handle = kbd_handler.handle; handle; handle = handle->hnext)
+ if (handle->dev->keycodesize) break;
+
+ if (!handle->dev->keycodesize)
+ return -ENODEV;
if we reach termination for the loop without finding a keycodesize, handle
will be NULL, so you'd get an oops. Just do:
+ if (!handle)
+ return -ENODEV
(sorry about the formatting, i'm reading l-k via uwsg's web archive).
--
Revolutions do not require corporate support.
next reply other threads:[~2002-08-25 21:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-25 21:14 Matthew Wilcox [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-08-20 13:38 [patch] Amiga input driver compile fixes Vojtech Pavlik
2002-08-21 17:10 ` [patch 1/2] Fix shift-pgup problems in i8042.c Vojtech Pavlik
[not found] ` <20020821191227.B6014@ucw.cz>
2002-08-21 20:32 ` [patch] Franz Sirl's final PPC input conversion part Vojtech Pavlik
2002-08-22 9:09 ` [patch] Two minor fixes for the PPC input conversion Vojtech Pavlik
2002-08-25 13:25 ` [patch] (re)implement setkeycode/getkeycode/kd_mksound/kbd_setrate via the input core Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020825221427.A6931@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®