mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Felix Seeger <felix.seeger@gmx.de>
To: linux-kernel@vger.kernel.org
Subject: Re: USB keyboards (patch)
Date: Tue, 27 Aug 2002 07:50:49 +0200	[thread overview]
Message-ID: <200208270750.49576.felix.seeger@gmx.de> (raw)
In-Reply-To: <200208270100.09037.nahshon@actcom.co.il>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Does this Patch solves the kernel panic on startup with USB Mouse plugged in 
the second usb part and MS Usb keyboard plugged in the first port ?

thanks
have fun
Felix

Am Dienstag, 27. August 2002 00:00 schrieb Itai Nahshon:
> Vojtech, Would you accept this for the 2.4 kernels?
>
> The attached patch is required to use some (buggy?)
> USB keyboards. IMHO it should not cause new problems
> with other HID devices (though, testing with hardware that
> I do not have is a good idea).
>
> I'm using it with recent 2.4 kernels for some time now.
>
> Just removing the call to usb_set_idle also works (but
> it is less efficient).
>
> The 2.5 kernels do not need this changes - they already call
> the equivalent of usb_set_idle (only for input reports) after
> reading the first report.
>
> -- Itai
>
> --- linux/drivers/usb/hid-core.c.orig	Sun Jul 21 01:19:32 2002
> +++ linux/drivers/usb/hid-core.c	Sun Jul 21 02:19:31 2002
> @@ -1065,8 +1065,8 @@
>  			list = report_enum->report_list.next;
>  			while (list != &report_enum->report_list) {
>  				report = (struct hid_report *) list;
> -				usb_set_idle(hid->dev, hid->ifnum, 0, report->id);
>  				hid_read_report(hid, report);
> +				usb_set_idle(hid->dev, hid->ifnum, 0, report->id);
>  				list = list->next;
>  			}
>  		}
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9axM5S0DOrvdnsewRApKfAJ9sD2I/61znoiV0MEJXHCjgvNGuVACfRidm
5vdlQPwSXEvzd/TxD4FbI+s=
=xkNg
-----END PGP SIGNATURE-----


  reply	other threads:[~2002-08-27  5:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-26 22:00 Itai Nahshon
2002-08-27  5:50 ` Felix Seeger [this message]
2002-08-27  6:28   ` Thunder from the hill
2002-08-27  6:33   ` Itai Nahshon
2002-08-27  6:39     ` Felix Seeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200208270750.49576.felix.seeger@gmx.de \
    --to=felix.seeger@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®