From: Vojtech Pavlik <vojtech@suse.cz>
To: Pavel Machek <pavel@ucw.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>
Subject: Re: input u-cleanup
Date: Thu, 29 Aug 2002 08:17:36 +0200 [thread overview]
Message-ID: <20020829081736.A23935@ucw.cz> (raw)
In-Reply-To: <20020828220603.GA30107@elf.ucw.cz>; from pavel@ucw.cz on Thu, Aug 29, 2002 at 12:06:03AM +0200
On Thu, Aug 29, 2002 at 12:06:03AM +0200, Pavel Machek wrote:
> Hi!
>
> proc is clever enough not to need ifdefs, so this is probably good
> idea...
>
> Pavel
If you could remove all the procfs #ifdefs from input.c, that'd be great.
But removing only those around unregistration IMHO doesn't make sense.
>
> --- clean/drivers/input/input.c Wed Aug 28 22:38:46 2002
> +++ linux-swsusp/drivers/input/input.c Wed Aug 28 23:28:23 2002
> @@ -800,11 +803,9 @@
>
> static void __exit input_exit(void)
> {
> -#ifdef CONFIG_PROC_FS
> remove_proc_entry("devices", proc_bus_input_dir);
> remove_proc_entry("handlers", proc_bus_input_dir);
> remove_proc_entry("input", proc_bus);
> -#endif
> devfs_unregister(input_devfs_handle);
> if (unregister_chrdev(INPUT_MAJOR, "input"))
> printk(KERN_ERR "input: can't unregister char major %d", INPUT_MAJOR);
>
> --
> Worst form of spam? Adding advertisment signatures ala sourceforge.net.
> What goes next? Inserting advertisment *into* email?
--
Vojtech Pavlik
SuSE Labs
next prev parent reply other threads:[~2002-08-29 6:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-28 22:06 Pavel Machek
2002-08-29 6:17 ` Vojtech Pavlik [this message]
2002-08-29 22:26 ` Pavel Machek
2002-08-30 5:37 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020829081736.A23935@ucw.cz \
--to=vojtech@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®