From: pwaechtler@mac.com
To: linux-kernel@vger.kernel.org
Cc: torvalds@transmeta.com
Subject: [PATCH] 14/41 sound/oss/uart6850.c - convert cli to spinlocks
Date: Thu, 29 Aug 2002 21:56:27 +0200 [thread overview]
Message-ID: <200208292155.g7TLteVw009198@smtp-relay01.mac.com> (raw)
--- vanilla-2.5.32/sound/oss/uart6850.c Sat Apr 20 18:25:21 2002
+++ linux-2.5-cli-oss/sound/oss/uart6850.c Tue Aug 13 15:51:12 2002
@@ -23,7 +23,7 @@
#include <linux/init.h>
#include <linux/module.h>
-
+#include <linux/spinlock.h>
/* Mon Nov 22 22:38:35 MET 1993 marco@driq.home.usn.nl:
* added 6850 support, used with COVOX SoundMaster II and custom cards.
*/
@@ -71,6 +71,7 @@
static int uart6850_irq;
static int uart6850_detected;
static int my_dev;
+static spinlock_t lock=SPIN_LOCK_UNLOCKED;
static void (*midi_input_intr) (int dev, unsigned char data);
static void poll_uart6850(unsigned long dummy);
@@ -122,9 +123,7 @@
if (!(uart6850_opened & OPEN_READ))
return; /* Device has been closed */
- save_flags(flags);
- cli();
-
+ spin_lock_irqsave(&lock,flags);
if (input_avail())
uart6850_input_loop();
@@ -135,7 +134,7 @@
* Come back later
*/
- restore_flags(flags);
+ spin_unlock_irqrestore(&lock,flags);
}
static int uart6850_open(int dev, int mode,
@@ -176,13 +175,12 @@
* Test for input since pending input seems to block the output.
*/
- save_flags(flags);
- cli();
+ spin_lock_irqsave(&lock,flags);
if (input_avail())
uart6850_input_loop();
- restore_flags(flags);
+ spin_unlock_irqrestore(&lock,flags);
/*
* Sometimes it takes about 13000 loops before the output becomes ready
@@ -265,15 +263,14 @@
uart6850_osp = hw_config->osp;
uart6850_irq = hw_config->irq;
- save_flags(flags);
- cli();
+ spin_lock_irqsave(&lock,flags);
for (timeout = 30000; timeout > 0 && !output_ready(); timeout--); /*
* Wait
*/
uart6850_cmd(UART_MODE_ON);
ok = 1;
- restore_flags(flags);
+ spin_unlock_irqrestore(&lock,flags);
conf_printf("6850 Midi Interface", hw_config);
reply other threads:[~2002-08-29 22:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200208292155.g7TLteVw009198@smtp-relay01.mac.com \
--to=pwaechtler@mac.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®