From: Jean Tourrilhes <jt@bougret.hpl.hp.com>
To: "B. Joshua Rosen" <bjrosen@polybus.com>, hch@lst.de
Cc: jgarzik@mandrakesoft.com,
Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: Compilation errors in 2.4.20.rc5
Date: Thu, 29 Aug 2002 19:35:05 -0700 [thread overview]
Message-ID: <20020830023504.GC14559@bougret.hpl.hp.com> (raw)
In-Reply-To: <1030673385.30059.4.camel@yorktown>
On Thu, Aug 29, 2002 at 10:09:45PM -0400, B. Joshua Rosen wrote:
> -o wavelan_cs.o wavelan_cs.c
> In file included from wavelan_cs.c:66:
> /home/tmp/linux/include/linux/ethtool.h:18: parse error before `u32'
> /home/tmp/linux/include/linux/ethtool.h:18: warning: no semicolon at end
> of struct or union
> /home/tmp/linux/include/linux/ethtool.h:19: warning: type defaults to
> `int' in declaration of `supported'
Ok, I'll forward...
hch@lst.de (or whoever did that) :
1) I don't really think that a wireless driver will get much
benefit from ethtool (try setting full duplex ;-)
2) Headers are added in the file wavelan_cs.h, to keep
wavelan.c clean and tidy. And this would have avoided the bug.
3) It take only 2 second to try to compile before submitting
your changes. Even the best of us do it.
4) A MAINTAINER is not someone that clean up after the mess of
other people. I usually answer my e-mail, and I could have both answer
your question and reviewed the patch.
So, please clean up your mess...
Jean
parent reply other threads:[~2002-08-30 2:30 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1030673385.30059.4.camel@yorktown>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020830023504.GC14559@bougret.hpl.hp.com \
--to=jt@bougret.hpl.hp.com \
--cc=bjrosen@polybus.com \
--cc=hch@lst.de \
--cc=jgarzik@mandrakesoft.com \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®