From: Russell King <rmk@arm.linux.org.uk>
To: Ingo Oeser <ingo.oeser@informatik.tu-chemnitz.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.32-bug
Date: Sat, 31 Aug 2002 18:14:38 +0100 [thread overview]
Message-ID: <20020831181438.A2047@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20020831140007.C781@nightmaster.csn.tu-chemnitz.de>; from ingo.oeser@informatik.tu-chemnitz.de on Sat, Aug 31, 2002 at 02:00:08PM +0200
On Sat, Aug 31, 2002 at 02:00:08PM +0200, Ingo Oeser wrote:
> Hi Rusty,
Grr.
> On Fri, Aug 30, 2002 at 10:39:12PM +0100, Russell King wrote:
> > This patch appears not to be in 2.5.32, but applies cleanly.
> >
> > This patch moves BUG() and PAGE_BUG() from asm/page.h into asm/bug.h.
> >
> > We also fix up linux/dcache.h, which included asm/page.h for the sole
> > purpose of getting the BUG() definition.
> >
> > Since linux/kernel.h makes use of BUG(), asm/bug.h is included there
> > as well.
> > --- orig/include/asm-cris/bug.h Thu Jan 1 01:00:00 1970
> > +++ linux/include/asm-cris/bug.h Sun Jan 6 11:46:09 2002
> > @@ -0,0 +1,12 @@
> > +#ifndef _CRIS_BUG_H
> > +#define _CRIS_BUG_H
> > +
> > +#define BUG() do { \
> > + printk("kernel BUG at %s:%d!\n", __FILE__, __LINE__); \
> > +} while (0)
> > +
> > +#define PAGE_BUG(page) do { \
> > + BUG(); \
> > +} while (0)
> > +
> > +#endif
>
> These kind of implementation of BUG() is not very useful. Callers
> of BUG() and BUG_ON() assume, that the thread is aborted and do
> nothing to fixup after BUG().
Nevertheless, its not up to me to change the implementation that an
architecture has chosen. That's for the individual port maintainers
to fix.
This patch only cleans up the include for the bug stuff so its in a
less silly place. There are _zero_ functional code changes.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2002-08-31 17:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-30 21:39 Russell King
2002-08-31 12:00 ` Ingo Oeser
2002-08-31 17:14 ` Russell King [this message]
2002-09-02 6:51 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020831181438.A2047@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=ingo.oeser@informatik.tu-chemnitz.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome