mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tomas Szepe <szepe@pinerecords.com>
To: "David S. Miller" <davem@redhat.com>
Cc: marcelo@conectiva.com.br, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] warnkill trivia 2/2
Date: Sun, 1 Sep 2002 13:37:42 +0200	[thread overview]
Message-ID: <20020901113741.GM32122@louise.pinerecords.com> (raw)
In-Reply-To: <20020901.042539.63049493.davem@redhat.com>

>    From: Tomas Szepe <szepe@pinerecords.com>
>    Date: Sun, 1 Sep 2002 13:28:56 +0200
> 
>    > I think you mean something like "atomic_t const * v" which means the
>    > pointer is constant, not the value.
>    
>    Precisely.
> 
> BTW who even passes around const atomic_t's?  Ie. what
> genrated the warning and made you even edit this to begin with?

fs/reiserfs/buffer2.c, line ~28:
atomic_t gets the const quality on account of being a member
of a const struct buffer_head instance.

void wait_buffer_until_released (const struct buffer_head * bh)
{
  int repeat_counter = 0;

  while (atomic_read (&(bh->b_count)) > 1) {

    if ( !(++repeat_counter % 30000000) ) {
      reiserfs_warning ("vs-3050: wait_buffer_until_released: nobody releases buffer (%b). Still waiting (%d) %cJDIRTY %cJWAIT\n",
			bh, repeat_counter, buffer_journaled(bh) ? ' ' : '!',
			buffer_journal_dirty(bh) ? ' ' : '!');
    }
    run_task_queue(&tq_disk);
    yield();
  }
  if (repeat_counter > 30000000) {
    reiserfs_warning("vs-3051: done waiting, ignore vs-3050 messages for (%b)\n", bh) ;
  }
}

  reply	other threads:[~2002-09-01 11:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-01 10:56 Tomas Szepe
2002-09-01 10:57 ` David S. Miller
2002-09-01 11:28   ` Tomas Szepe
2002-09-01 11:25     ` David S. Miller
2002-09-01 11:37       ` Tomas Szepe [this message]
2002-09-01 11:35         ` David S. Miller
2002-09-01 12:10           ` Tomas Szepe
2002-09-01 12:16             ` David S. Miller
2002-09-01 12:39               ` Tomas Szepe
2002-09-01 21:57                 ` Bruce Guenter
2002-09-02 22:24     ` Jan Hudec
2002-09-01 15:27 ` [PATCH] warnkill trivia 2/2 (correction) Tomas Szepe
2002-09-01 14:52 [PATCH] warnkill trivia 2/2 Mikael Pettersson
2002-09-01 14:56 ` Tomas Szepe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020901113741.GM32122@louise.pinerecords.com \
    --to=szepe@pinerecords.com \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®