From: Rusty Russell <rusty@rustcorp.com.au>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org, davem@vger.kernel.org, akpm@zip.com.au
Subject: [PATCH] Important per-cpu fix.
Date: Wed, 04 Sep 2002 12:35:41 +1000 [thread overview]
Message-ID: <20020904023535.73D922C12D@lists.samba.org> (raw)
Frankly, I'm amazed the kernel worked for long without this.
Every linker script thinks the section is called .data.percpu.
Without this patch, every CPU ends up sharing the same "per-cpu"
variable.
This might explain the wierd per-cpu problem reports from Andrew and
Dave, and also that nagging feeling that I'm an idiot...
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
--- working-2.5.33-hotcpu-cpudown-i386/include/asm-generic/percpu.h.~1~ Wed Aug 28 09:29:50 2002
+++ working-2.5.33-hotcpu-cpudown-i386/include/asm-generic/percpu.h Wed Sep 4 12:32:34 2002
@@ -10,7 +10,7 @@
/* Separate out the type, so (int[3], foo) works. */
#ifndef MODULE
#define DEFINE_PER_CPU(type, name) \
- __attribute__((__section__(".percpu"))) __typeof__(type) name##__per_cpu
+ __attribute__((__section__(".data.percpu"))) __typeof__(type) name##__per_cpu
#endif
/* var is in discarded region: offset to particular copy we want */
next reply other threads:[~2002-09-04 2:31 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-04 2:35 Rusty Russell [this message]
2002-09-04 2:54 ` David S. Miller
2002-09-04 4:04 ` Rusty Russell
2002-09-04 4:52 ` H. Peter Anvin
2002-09-09 8:06 ` Rusty Russell
2002-09-09 8:16 ` David S. Miller
2002-09-04 5:05 ` David S. Miller
2002-09-04 5:17 ` Linus Torvalds
2002-09-04 5:12 ` David S. Miller
2002-09-04 6:00 ` Rusty Russell
2002-09-04 6:06 ` David S. Miller
2002-09-04 6:19 ` David S. Miller
2002-09-04 7:38 ` Rusty Russell
2002-09-06 9:57 ` Pavel Machek
2002-09-09 3:45 ` Rusty Russell
2002-09-09 6:13 ` David S. Miller
2002-09-09 8:17 ` Rusty Russell
2002-09-09 8:15 ` David S. Miller
2002-09-09 20:58 ` Alan Cox
2002-09-09 21:06 ` Andrew Morton
2002-09-10 9:41 ` Rusty Russell
2002-09-04 15:44 ` Thunder from the hill
2002-09-04 23:18 ` David S. Miller
2002-09-04 2:56 ` Andrew Morton
2002-09-04 2:46 ` William Lee Irwin III
2002-09-04 3:42 ` William Lee Irwin III
2002-09-05 9:10 Dipankar Sarma
2002-09-05 9:09 ` William Lee Irwin III
2002-09-05 19:08 ` Dipankar Sarma
2002-09-05 19:11 ` William Lee Irwin III
2002-09-09 12:17 Matthew Wilcox
2002-09-09 23:24 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020904023535.73D922C12D@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=akpm@zip.com.au \
--cc=davem@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome