From: Sam Ravnborg <sam@ravnborg.org>
To: Karim Yaghmour <karim@opersys.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
LTT-Dev <ltt-dev@shafik.org>
Subject: Re: [PATCH] 1/8 LTT for 2.5.34: Core infrastructure
Date: Tue, 10 Sep 2002 20:40:41 +0200 [thread overview]
Message-ID: <20020910204041.A2197@mars.ravnborg.org> (raw)
In-Reply-To: <3D7E36E2.625141D6@opersys.com>; from karim@opersys.com on Tue, Sep 10, 2002 at 02:16:02PM -0400
On Tue, Sep 10, 2002 at 02:16:02PM -0400, Karim Yaghmour wrote:
> +ifdef CONFIG_TRACE
> +obj-y += trace.o
> endif
This is still bogus.
The day that CONFIG_TRACE equals n you will still include trace.o.
An explicit test for m or y is preferable.
On the other hand there is a lot of places in the makefiles that gets this
wrong - sigh.
Sam
next prev parent reply other threads:[~2002-09-10 18:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-10 18:16 Karim Yaghmour
2002-09-10 18:22 ` Karim Yaghmour
2002-09-10 18:40 ` Sam Ravnborg [this message]
2002-09-10 18:46 ` Karim Yaghmour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020910204041.A2197@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=karim@opersys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ltt-dev@shafik.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome