Re: Linux 2.4.20-pre6

[Jean Tourrilhes <jt@bougret.hpl.hp.com>]

Adrian Bunk wrote :
> >...
> > Alan Cox <alan@lxorguk.ukuu.org.uk>:
> >...
> >   o more irda __FUNCTION__ stuff
> >...
> 
> This adds the use of TIOCM_MODEM_BITS to irtty.c but not the corresponding
> addition of it to asm-i386/termios.h:

	I would personally would have veto'ed that change, because it
will work only on i386 (and PA-Risc), whereas the IrDA stack is
routinely used on ARM and PPC and also work on Alpha.
	That's the kind of shortsighted quick hack that make life
painfull for everybody, because we now have to fix a dozen
platforms. Last time I heard, 2.4.X was supposed to be the "stable"
kernel.
	I would personally perfer the header to define a "default"
value, and only the broken architecture would need to override it
(#undef + #define).
	Actually, the previous solution of having the cruft hidden in
the irtty driver with #ifdef and not poluting the generic kernel was
also pretty good IMHO, and I don't understand why the original author
didn't go along those lines (sure he didn't told me why).

	Of course, I'm opiniated...

	So, as people like quick'n'dirty hacks, just make sure that
TIOCM_MODEM_BITS is also defined in ARM, SH, PPC and Alpha (at least),
just to make sure I'm the only one complaining.

	Thanks in advance...

	Jean