From: Jean Tourrilhes <jt@bougret.hpl.hp.com>
To: Marcelo Tosatti <marcelo@conectiva.com.br>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: [PATCH 2.4.20] Fix stupid compile error in wavelan_cs
Date: Wed, 11 Sep 2002 16:18:38 -0700 [thread overview]
Message-ID: <20020911231838.GA32265@bougret.hpl.hp.com> (raw)
Hi,
This fix the stupid compile error introduce by some careless
hacker in the wavelan_cs driver.
This is the *right* fix that avoid header duplication, do not
accept substitutes ;-)
Alan told me that he was going to send you the fix for the
irtty compile error.
Have fun...
Jean
------------------------------------------------------------
diff -u -p linux/drivers/net/pcmcia/wavelan_cs.b1.h linux/drivers/net/pcmcia/wavelan_cs.h
--- linux/drivers/net/pcmcia/wavelan_cs.b1.h Wed Sep 11 16:01:58 2002
+++ linux/drivers/net/pcmcia/wavelan_cs.h Wed Sep 11 16:11:14 2002
@@ -432,6 +432,7 @@
#include <linux/if_arp.h>
#include <linux/ioport.h>
#include <linux/fcntl.h>
+#include <linux/ethtool.h>
#ifdef CONFIG_NET_PCMCIA_RADIO
#include <linux/wireless.h> /* Wireless extensions */
diff -u -p linux/drivers/net/pcmcia/wavelan_cs.b1.c linux/drivers/net/pcmcia/wavelan_cs.c
--- linux/drivers/net/pcmcia/wavelan_cs.b1.c Wed Sep 11 16:01:52 2002
+++ linux/drivers/net/pcmcia/wavelan_cs.c Wed Sep 11 16:11:11 2002
@@ -63,8 +63,7 @@
*
*/
-#include <linux/ethtool.h>
-#include <asm/uaccess.h>
+/* Do *NOT* add other headers here, you are guaranteed to be wrong - Jean II */
#include "wavelan_cs.h" /* Private header */
/************************* MISC SUBROUTINES **************************/
reply other threads:[~2002-09-11 23:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020911231838.GA32265@bougret.hpl.hp.com \
--to=jt@bougret.hpl.hp.com \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®