From: "Adam J. Richter" <adam@yggdrasil.com>
To: andre@linux-ide.org, alan@lxorguk.ukuu.org.uk, axboe@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: Patch: linux-2.5.34/drivers/ide/ide.c was building list of drives in reverse order
Date: Thu, 12 Sep 2002 04:48:51 -0700 [thread overview]
Message-ID: <20020912044851.A382@baldur.yggdrasil.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 970 bytes --]
ata_attach in linux-2.5.34/drivers/ide/ide.c builds a list of
IDE drives that do not yet have a device driver bound to them, in case
ide-disk, ide-scsi, or whatever driver you want to use is not loaded
yet.
The problem was that ata_attach was adding to the head of
the list, so the list was being built in reverse order. So, if
you had two IDE disks, and ide-disk was a loadable module, the
devfs entries for the disks would be numbered in reverse (the
first disk would be /dev/discs/disc1, and the second would be
/dev/discs/disc0).
The follow patch fixes the problem by changing the relevant
list_add to list_add_tail. Incidentally, the generic code
in drivers/base/ already does it this way.
--
Adam J. Richter __ ______________ 575 Oroville Road
adam@yggdrasil.com \ / Milpitas, California 95035
+1 408 309-6081 | g g d r a s i l United States of America
"Free Software For The Rest Of Us."
[-- Attachment #2: ide.diff --]
[-- Type: text/plain, Size: 474 bytes --]
--- linux-2.5.34/drivers/ide/ide.c 2002-09-09 10:35:06.000000000 -0700
+++ linux/drivers/ide/ide.c 2002-09-12 04:30:20.000000000 -0700
@@ -2478,11 +2478,11 @@
if (driver->owner)
__MOD_DEC_USE_COUNT(driver->owner);
}
spin_unlock(&drivers_lock);
spin_lock(&drives_lock);
- list_add(&drive->list, &ata_unused);
+ list_add_tail(&drive->list, &ata_unused);
spin_unlock(&drives_lock);
return 1;
}
static int ide_ioctl (struct inode *inode, struct file *file,
next reply other threads:[~2002-09-12 11:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-12 11:48 Adam J. Richter [this message]
2002-09-12 11:52 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020912044851.A382@baldur.yggdrasil.com \
--to=adam@yggdrasil.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andre@linux-ide.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®