From: "David S. Miller" <davem@redhat.com>
To: akropel1@rochester.rr.com
Cc: linux-kernel@vger.kernel.org, alan@redhat.com
Subject: Re: Streaming DMA mapping question
Date: Fri, 13 Sep 2002 13:28:42 -0700 (PDT) [thread overview]
Message-ID: <20020913.132842.97163812.davem@redhat.com> (raw)
In-Reply-To: <20020913202150.GA24340@www.kroptech.com>
From: Adam Kropelin <akropel1@rochester.rr.com>
Date: Fri, 13 Sep 2002 16:21:50 -0400
On Fri, Sep 13, 2002 at 12:36:41PM -0700, David S. Miller wrote:
> Actually, rather it appears that the i386 pci_unmap_*() routines need
> the write buffer flush as well.
Ah, a bug then.
On further discussion with Alan Cox, the bug is actually that
pci_map_*() needs the write buffer flush added. pci_map_*()
and pci_dma_sync_*() transfer ownership from CPU to PCI controller
as abstracted in DMA-mapping.txt Therefore these are the cases
where the CPU write buffers need to be flushed.
pci_unmap_*() is ok as-is.
I was looking at the x86 implementation to help me narrow down the possible
source of a bug I'm seeing in the driver. I noticed the driver was examining a
DMA buffer without unmapping or syncing.
Really, the cases handled by the x86 write buffer fluses are very
marginal and unlikely to happen. In fact the write buffer flush on
x86 is done on winchip and ppro chips only.
I think you're problems are elsewhere :-)
Kudos to you and others who spent time writing it.
Thank you.
next prev parent reply other threads:[~2002-09-13 20:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-13 19:39 Adam Kropelin
2002-09-13 19:36 ` David S. Miller
2002-09-13 20:21 ` Adam Kropelin
2002-09-13 20:28 ` David S. Miller [this message]
2002-09-13 20:52 ` Adam Kropelin
2002-09-13 20:46 ` David S. Miller
2002-09-14 3:51 ` Adam Kropelin
2002-09-16 3:30 ` David S. Miller
2002-09-16 21:06 ` Martin Diehl
2002-09-16 20:56 ` David S. Miller
2002-09-16 21:51 ` Martin Diehl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020913.132842.97163812.davem@redhat.com \
--to=davem@redhat.com \
--cc=akropel1@rochester.rr.com \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome