From: Pavel Machek <pavel@ucw.cz>
To: James Blackwell <jblack@linuxguru.net>
Cc: linux-kernel@vger.kernel.org, hch@infradead.org, jonathan@buzzard.org.uk
Subject: Re: [PATCH] IRQ patch for Toshiba Char Driver in 2.5.34
Date: Sun, 15 Sep 2002 22:02:02 +0200 [thread overview]
Message-ID: <20020915200202.GA15744@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <20020915195328.GA60517@comet>
Hi!
> > > > You've just made the driver horribly racy on SMP or preempt
> > > > systems..
> > >
> > > Well, as long as toshiba does not make SMP notebooks, we are safe ;-).
> >
> > ... or preempt. Which doesn't really depend on Toshiba.
> >
>
> Does that mean my very first kernel patch, insignificant as it is, is
> probably acceptable?
>
> Should I resubmit it? I haven't tried 2.5.34 yet, and 2.5.33 had keyboard
> problems that prevented me from using it.
Perhaps adding #ifdef CONFIG_SMP #error Not SMP safe, #ifdef
CONFIG_PREEMPT #error Not preempt safe and resubmitting is not such a
bad idea.
It would be nice to make it preempt/smp safe, through. [SMP notebooks
are not so unreasonable; think p4 hyperthreading].
Pavel
--
Casualities in World Trade Center: ~3k dead inside the building,
cryptography in U.S.A. and free speech in Czech Republic.
next prev parent reply other threads:[~2002-09-15 19:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-09 11:59 James Blackwell
2002-09-09 19:39 ` Zwane Mwaikambo
2002-09-11 10:29 ` Christoph Hellwig
2002-09-15 15:42 ` Pavel Machek
2002-09-15 19:30 ` Vojtech Pavlik
2002-09-15 19:53 ` James Blackwell
2002-09-15 20:02 ` Pavel Machek [this message]
2002-09-15 22:27 ` Dave Jones
2002-09-15 23:39 ` Jonathan Buzzard
2002-09-16 11:59 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020915200202.GA15744@atrey.karlin.mff.cuni.cz \
--to=pavel@ucw.cz \
--cc=hch@infradead.org \
--cc=jblack@linuxguru.net \
--cc=jonathan@buzzard.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®