From: Matthew Wilcox <willy@debian.org>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: problem with "Use CLONE_KERNEL for the common kernel thread flags"?
Date: Sun, 15 Sep 2002 22:54:19 +0100 [thread overview]
Message-ID: <20020915225419.F10583@parcelfarce.linux.theplanet.co.uk> (raw)
Seems to me like you missed something in your latest changeset:
-#define CLONE_SIGNAL (CLONE_SIGHAND | CLONE_THREAD)
+#define CLONE_KERNEL (CLONE_FS | CLONE_FILES | CLONE_SIGHAND)
- kernel_thread(init, NULL, CLONE_FS | CLONE_FILES | CLONE_SIGNAL);
+ kernel_thread(init, NULL, CLONE_KERNEL);
init used to be spawned with CLONE_THREAD and no longer is. Was this
intentional? The changelog entry didn't indicate it, and I haven't
been keeping track of what all the CLONE flags mean these days so I'm
not sure if this is safe.
--
Revolutions do not require corporate support.
next reply other threads:[~2002-09-15 21:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-15 21:54 Matthew Wilcox [this message]
2002-09-15 21:56 ` Ingo Molnar
2002-09-15 23:59 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020915225419.F10583@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®