mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Badari Pulavarty <pbadari@us.ibm.com>
To: bcrl@redhat.com (Benjamin LaHaise)
Cc: pbadari@us.ibm.com (Badari Pulavarty),
	linux-kernel@vger.kernel.org, linux-aio@kvack.org
Subject: Re: [RFC] [PATCH] 2.5.35 patch for making DIO async
Date: Wed, 18 Sep 2002 08:58:22 -0700 (PDT)	[thread overview]
Message-ID: <200209181558.g8IFwNp14249@eng2.beaverton.ibm.com> (raw)
In-Reply-To: <20020918075103.B6143@redhat.com> from "Benjamin LaHaise" at Sep 18, 2002 06:51:03 AM PST

> 
> On Tue, Sep 17, 2002 at 02:03:02PM -0700, Badari Pulavarty wrote:
> > Hi Ben,
> > 
> > Here is a 2.5.35 patch to make DIO async. Basically, DIO does not
> > wait for io completion. Waiting will be done at the higher level
> > (same way generic_file_read does).
> 
> This looks pretty good.  Andrew Morton has had a look over it too and 
> agrees that it should go in after a bit of testing.  Does someone want 
> to try comparing throughput of dio based aio vs normal read/write?  It 
> would be interesting to see what kind of an effect pipelining aios makes 
> and if there are any performance niggles we need to squash.  Cheer,
> 
> 		-ben

Thanks for looking at the patch. Patch needed few cleanups to get it
working. Here is the status so far..

1) I tested synchronous raw read/write. They perform almost same as
   without this patch. I am looking at why I can't match the performance.
   (I get 380MB/sec on 40 dd's on 40 disks without this patch.
    I get 350MB/sec with this patch).

2) wait_on_sync_kiocb() needed blk_run_queues() to make regular read/
   write perform well.

3) I am testing aio read/writes. I am using libaio.0.3.92. 
   When I try aio_read/aio_write on raw device, I am get OOPS.
   Can I use libaio.0.3.92 on 2.5 ? Are there any interface
   changes I need to worry  between 2.4 and 2.5 ?

Once I get aio read/writes working, I will provide you the performance
numbers.

Thanks,
Badari


  reply	other threads:[~2002-09-18 15:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-17 21:03 Badari Pulavarty
2002-09-18 11:51 ` Benjamin LaHaise
2002-09-18 15:58   ` Badari Pulavarty [this message]
2002-09-18 16:04     ` Benjamin LaHaise
2002-09-18 16:30       ` Badari Pulavarty
2002-09-18 20:47         ` Badari Pulavarty
2002-09-19 10:52           ` Suparna Bhattacharya
2002-09-19 11:36             ` Suparna Bhattacharya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200209181558.g8IFwNp14249@eng2.beaverton.ibm.com \
    --to=pbadari@us.ibm.com \
    --cc=bcrl@redhat.com \
    --cc=linux-aio@kvack.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®