From: Matthew Wilcox <willy@debian.org>
To: Burton Windle <bwindle@fint.org>
Cc: linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-fsdevel@vger.kernel.org
Subject: Re: [2.5.36] oops when reading /proc/locks
Date: Thu, 19 Sep 2002 21:16:23 +0100 [thread overview]
Message-ID: <20020919211623.B10583@parcelfarce.linux.theplanet.co.uk> (raw)
[note: please cc me or linux-fsdevel when reporting file locking bugs;
i only read linux-kernel on the web and as time permits]
It looks to me like your dereference comes from this line:
if (fl->fl_file != NULL)
inode = fl->fl_file->f_dentry->d_inode;
and, if my terribly weak x86 assembler isn't deceiving me, f_dentry
is NULL. Since you can reproduce this at will, could you insert some
debugging for me?
if (fl->fl_file != NULL) {
if (fl->fl_file->f_dentry) {
inode = fl->fl_file->f_dentry->d_inode;
} else {
printk(KERN_EMERG "null dentry at %d\n", id);
}
}
That will avoid the oops, and tell us who managed to set a file lock on
a file without a dentry.
--
Revolutions do not require corporate support.
next reply other threads:[~2002-09-19 20:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-19 20:16 Matthew Wilcox [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-09-19 14:40 Burton Windle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020919211623.B10583@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=bwindle@fint.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®