From: Jeff Dike <jdike@karaya.com>
To: marcelo@conectiva.com.br
Cc: linux-kernel@vger.kernel.org, sapan@corewars.org
Subject: [PATCH] n_tty.c buglet breaks error returns
Date: Sat, 21 Sep 2002 13:58:30 -0400 [thread overview]
Message-ID: <200209211758.g8LHwUd17425@karaya.com> (raw)
The tty SIGIO fix that went into 2.4.19 breaks error returns from the
underlying driver. Currently, any errors from the driver causes write_chan
to call schedule() rather than returning the error.
This broke the UML test suite, the fix below makes it work again.
Jeff
--- orig/drivers/char/n_tty.c Tue Sep 3 17:07:15 2002
+++ um/drivers/char/n_tty.c Sat Sep 21 13:22:32 2002
@@ -1180,7 +1180,7 @@
while (nr > 0) {
ssize_t num = opost_block(tty, b, nr);
if (num < 0){
- if(num != -EAGAIN)
+ if(num == -EAGAIN)
break;
retval = num;
goto break_out;
next reply other threads:[~2002-09-21 17:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-21 17:58 Jeff Dike [this message]
2002-09-23 3:45 Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200209211758.g8LHwUd17425@karaya.com \
--to=jdike@karaya.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=sapan@corewars.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®