From: Tom Rini <trini@kernel.crashing.org>
To: Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
kbuild-devel@lists.sourceforge.net
Subject: [PATCH 2.5] Make scripts/Configure follow the definition of 'int'
Date: Tue, 24 Sep 2002 08:13:51 -0700 [thread overview]
Message-ID: <20020924151351.GA788@opus.bloom.county> (raw)
Currently, scripts/Configure has code for the 'int' verb to take a
min/max. This violates the spec described in
Documentation/kbuild/config-language.txt. It also requires that if a
default is outside of +/- 10,000,000 that defaults be provided, or
'config' and 'oldconfig' will get stuck. The following removes the
support for a min/max from scripts/Configure.
--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/
===== scripts/Configure 1.6 vs edited =====
--- 1.6/scripts/Configure Wed Jun 5 17:40:52 2002
+++ edited/scripts/Configure Tue Sep 24 07:58:59 2002
@@ -415,25 +415,15 @@
#
# int processes an integer argument with optional limits
#
-# int question define default [min max]
+# int question define default
#
function int () {
old=$(eval echo "\${$2}")
def=${old:-$3}
- if [ $# -gt 3 ]; then
- min=$4
- else
- min=-10000000 # !!
- fi
- if [ $# -gt 4 ]; then
- max=$5
- else
- max=10000000 # !!
- fi
rndval $2
while :; do
readln "$1 ($2) [$def] " "$def" "$old"
- if expr \( \( $ans + 0 \) \>= $min \) \& \( $ans \<= $max \) >/dev/null 2>&1 ; then
+ if expr "$ans" : '[0-9]*$' > /dev/null; then
define_int "$2" "$ans"
break
else
reply other threads:[~2002-09-24 15:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020924151351.GA788@opus.bloom.county \
--to=trini@kernel.crashing.org \
--cc=kai@tp1.ruhr-uni-bochum.de \
--cc=kbuild-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®