From: Mikael Pettersson <mikpe@csd.uu.se>
To: linux-kernel@vger.kernel.org
Cc: viro@math.psu.edu
Subject: [PATCH] fix 2.5.39 floppy driver
Date: Sat, 28 Sep 2002 21:14:04 +0200 (MET DST) [thread overview]
Message-ID: <200209281914.VAA06013@harpo.it.uu.se> (raw)
The 2.5.39 floppy driver is still broken. Jens' fix to ll_rw_block
was included in 2.5.39, so the kernel doesn't reboot at the first
I/O operation as it did in 2.5.38, but several problems remain:
1. Accessing /dev/fd0H1440 oopses fs/block_dev.c:do_open().
Fixed by applying Al Viro's O100-get_gendisk-C38 patch.
2. The capacity of floppies is halved.
Fixed by applying Al Viro's O101-floppy_sizes-C38 patch.
3. /dev/fd0 size autodetection doesn't work properly. The very
first read or write only transmits 2K (or 4K with Al's patches)
of data. I/O works after a reopen of /dev/fd0.
Explanation: the floppy interrupt handler updates floppy_sizes[],
but doesn't set_capacity() on the corresponding gendisk, causing
the detected size for /dev/fd0 to not be applied until the next
time /dev/fd0 is opened.
Quick fix: add the missing set_capacity() calls.
With Al's two patches and this one floppies work reliably for me.
/Mikael
--- linux-2.5.39/drivers/block/floppy.c.~1~ Sat Sep 28 12:42:00 2002
+++ linux-2.5.39/drivers/block/floppy.c Sat Sep 28 18:49:27 2002
@@ -778,6 +778,7 @@
"disk change\n");
current_type[drive] = NULL;
floppy_sizes[TOMINOR(drive)] = MAX_DISK_SIZE << 1;
+ set_capacity(&disks[drive], floppy_sizes[TOMINOR(drive)]);
}
/*USETF(FD_DISK_NEWCHANGE);*/
@@ -2426,6 +2427,7 @@
}
current_type[current_drive] = _floppy;
floppy_sizes[TOMINOR(current_drive) ]= _floppy->size+1;
+ set_capacity(&disks[current_drive], floppy_sizes[TOMINOR(current_drive)]);
break;
}
@@ -2435,6 +2437,7 @@
_floppy->name,current_drive);
current_type[current_drive] = _floppy;
floppy_sizes[TOMINOR(current_drive)] = _floppy->size+1;
+ set_capacity(&disks[current_drive], floppy_sizes[TOMINOR(current_drive)]);
probing = 0;
}
next reply other threads:[~2002-09-28 19:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-28 19:14 Mikael Pettersson [this message]
2002-09-28 20:22 ` John Levon
2002-09-28 21:12 ` Thomas Molina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200209281914.VAA06013@harpo.it.uu.se \
--to=mikpe@csd.uu.se \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®