From: Matthew Wilcox <willy@debian.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
Chuck Lever <cel@netapp.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux FSdevel <linux-fsdevel@vger.kernel.org>,
NFS maillist <nfs@lists.sourceforge.net>
Subject: Re: [PATCH] 2.4.20 Direct IO patch for NFS. (Note: a trivial API change...)
Date: Mon, 30 Sep 2002 19:52:35 +0100 [thread overview]
Message-ID: <20020930195235.P18377@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <15768.39196.468797.249573@charged.uio.no>; from trond.myklebust@fys.uio.no on Mon, Sep 30, 2002 at 08:34:04PM +0200
On Mon, Sep 30, 2002 at 08:34:04PM +0200, Trond Myklebust wrote:
> diff -u --recursive --new-file linux-2.4.20-pre8/fs/block_dev.c linux-2.4.20-directio/fs/block_dev.c
> --- linux-2.4.20-pre8/fs/block_dev.c Sun May 12 02:26:03 2002
> +++ linux-2.4.20-directio/fs/block_dev.c Mon Sep 30 18:24:45 2002
> @@ -131,8 +131,9 @@
> return 0;
> }
>
> -static int blkdev_direct_IO(int rw, struct inode * inode, struct kiobuf * iobuf, unsigned long blocknr, int blocksize)
> +static int blkdev_direct_IO(int rw, struct file * filp, struct kiobuf * iobuf, unsigned long blocknr, int blocksize)
> {
> + struct inode * inode = filp->f_dentry->d_inode->i_mapping->host;
> return generic_direct_IO(rw, inode, iobuf, blocknr, blocksize, blkdev_get_block);
> }
>
isn't that two dereferences more than necessary for a local filesystem?
--
Revolutions do not require corporate support.
next prev parent reply other threads:[~2002-09-30 18:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-30 18:34 Trond Myklebust
2002-09-30 18:42 ` Christoph Hellwig
2002-09-30 18:46 ` Trond Myklebust
2002-09-30 19:04 ` Andrew Morton
2002-09-30 19:18 ` Alan Cox
2002-09-30 18:52 ` Matthew Wilcox [this message]
2002-09-30 18:57 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020930195235.P18377@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=cel@netapp.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=nfs@lists.sourceforge.net \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®