From: Chris Wright <chris@wirex.com>
To: Robert Love <rml@tech9.net>
Cc: Daniel Jacobowitz <dan@debian.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Re: Capabilities-related change in 2.5.40
Date: Wed, 2 Oct 2002 09:44:17 -0700 [thread overview]
Message-ID: <20021002094417.D26557@figure1.int.wirex.com> (raw)
In-Reply-To: <1033569212.24108.20.camel@phantasy>; from rml@tech9.net on Wed, Oct 02, 2002 at 10:33:32AM -0400
* Robert Love (rml@tech9.net) wrote:
> On Wed, 2002-10-02 at 09:23, Daniel Jacobowitz wrote:
>
> > How very odd. I have been running 2.5 on that machine for a while, and
> > the bug only showed up somewhere between 2.5.36 and 2.5.40. Maybe a
> > coincidence triggered by the PID hashing... your tabbing is a little
> > odd but the patch looks right to me. Thanks!
>
> I too wonder if the bug is due to the pid changes and not me :)
No way man! ;-)
> find_task_by_pid(0) should just return current, which was my intention
> to avoid conditional code-paths. Maybe I should of used
> find_process_by_pid()... it seems in the latest 2.5 that still returns
> current if !pid, at least.
kernel/sched.c::static inline task_t *find_process_by_pid...
Guess that won't work w/out more changes. Perhaps it's simpler/safer
to be just be explicit in this case.
thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
next prev parent reply other threads:[~2002-10-02 16:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-01 16:49 Daniel Jacobowitz
2002-10-01 20:45 ` Chris Wright
2002-10-01 21:12 ` Daniel Jacobowitz
2002-10-02 7:38 ` [PATCH] " Chris Wright
2002-10-02 13:23 ` Daniel Jacobowitz
2002-10-02 14:33 ` Robert Love
2002-10-02 16:44 ` Chris Wright [this message]
2002-10-02 18:10 ` Robert Love
2002-10-02 18:21 ` Chris Wright
2002-10-02 16:25 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021002094417.D26557@figure1.int.wirex.com \
--to=chris@wirex.com \
--cc=dan@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®