Re: kernel BUG at slab.c:1292

[Petr Vandrovec <vandrove@vc.cvut.cz>]

On Wed, Oct 02, 2002 at 07:35:51PM +0100, Peter L Jones wrote:
> Hi all,
> 
> I asked on #kernelnewbies what I should do with this and was told to check the 
> mailing list archive at http://marc.theaimsgroup.com/ - which I've done.
> 
> The following was produced during boot.  I _looks_ like it was during a 
> modprobe, but I'm not entirely sure what - it could be that binfmt_misc but I 
> couldn't find any docs in the tree for BUG() tracebacks (and I probably 
> wouldn't have understood the source).
> 
> I'm not subscribed to the list: if anyone wants more info, drop me private 
> mail and I'll see what I can do.

Try this. I just sent it to Linus.
						Petr Vandrovec

diff -urdN linux/fs/fat/inode.c linux/fs/fat/inode.c
--- linux/fs/fat/inode.c	2002-10-02 13:20:19.000000000 +0200
+++ linux/fs/fat/inode.c	2002-10-02 19:54:59.000000000 +0200
@@ -228,8 +228,6 @@
 	save = 0;
 	savep = NULL;
 	while ((this_char = strsep(&options,",")) != NULL) {
-		if (!*this_char)
-			continue;
 		if ((value = strchr(this_char,'=')) != NULL) {
 			save = *value;
 			savep = value;
@@ -351,7 +349,7 @@
 			strncpy(cvf_options,value,100);
 		}
 
-		if (this_char != options) *(this_char-1) = ',';
+		if (options) *(options-1) = ',';
 		if (value) *savep = save;
 		if (ret == 0)
 			break;
diff -urdN linux/fs/vfat/namei.c linux/fs/vfat/namei.c
--- linux/fs/vfat/namei.c	2002-10-02 13:20:27.000000000 +0200
+++ linux/fs/vfat/namei.c	2002-10-02 19:54:28.000000000 +0200
@@ -117,8 +117,6 @@
 	savep = NULL;
 	ret = 1;
 	while ((this_char = strsep(&options,",")) != NULL) {
-		if (!*this_char)
-			continue;
 		if ((value = strchr(this_char,'=')) != NULL) {
 			save = *value;
 			savep = value;
@@ -154,8 +152,8 @@
 			else
 				ret = 0;
 		}
-		if (this_char != options)
-			*(this_char-1) = ',';
+		if (options)
+			*(options-1) = ',';
 		if (value) {
 			*savep = save;
 		}