mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: zaitcev@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: virt_to_page(pci_alloc_consistent())
Date: Thu, 03 Oct 2002 01:03:44 -0700 (PDT)	[thread overview]
Message-ID: <20021003.010344.123986131.davem@redhat.com> (raw)
In-Reply-To: <20021003023814.A5856@devserv.devel.redhat.com>

   From: Pete Zaitcev <zaitcev@redhat.com>
   Date: Thu, 3 Oct 2002 02:38:14 -0400

   I just noticed that sound drivers use the address from
   pci_alloc_consistent() as the input to virt_to_page() all
   over the place. I looked into the Documentation/DMA-mapping.txt,
   and it says:
   
     This routine will allocate RAM for that region, so it acts similarly to
     __get_free_pages (but takes size instead of a page order).
   
   I know for fact I got it wrong in sparc in whole 2.4, and it seems
   RMK got it wrong in arm. I suggest other architecture maintainers
   to look at it ASAP. May even be oopsabe, by indexing outside of
   mem_map[] with a suitable sound driver.

I think we MUST allow architectures to do what SPARC and ARM
do, there is simply no other way to change the page protections
easily for these kinds of systems.

So please instead change the DMA-mapping.txt documentation and
propose pci_consistent_to_page(ptr) API additions.  Next, inform
the subsytems trying to use virt_to_page() on this memory that
they need to use the new interface.

  reply	other threads:[~2002-10-03  8:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-03  6:38 virt_to_page(pci_alloc_consistent()) Pete Zaitcev
2002-10-03  8:03 ` David S. Miller [this message]
2002-10-03 16:25   ` virt_to_page(pci_alloc_consistent()) Pete Zaitcev
2002-10-03 17:11     ` virt_to_page(pci_alloc_consistent()) David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021003.010344.123986131.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zaitcev@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®