From: Francois Romieu <romieu@cogenit.fr>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cli()/sti() fix for drivers/net/depca.c
Date: Thu, 3 Oct 2002 18:40:41 +0200 [thread overview]
Message-ID: <20021003184041.A29041@se1.cogenit.fr> (raw)
In-Reply-To: <200210030743.g937hBp01523@Port.imtp.ilyichevsk.odessa.ua>; from vda@port.imtp.ilyichevsk.odessa.ua on Thu, Oct 03, 2002 at 10:37:03AM -0200
Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua> :
[...]
> > depca_rx() looks strange:
> > buf = skb_put(skb, len);
> > [...]
> > netif_rx(skb);
> > [...]
> > if (buf[0] & ...)
>
> I'd say this network stuff is a bit cryptic for untrained eye :-)
> What's strange with that code?
One shouldn't assume the buffer is available once it was passed to
netif_rx().
--
Ueimor
next prev parent reply other threads:[~2002-10-03 16:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-03 0:58 Denis Vlasenko
2002-10-02 20:40 ` Francois Romieu
2002-10-03 2:26 ` Denis Vlasenko
2002-10-02 22:12 ` Francois Romieu
2002-10-03 12:37 ` Denis Vlasenko
2002-10-03 16:40 ` Francois Romieu [this message]
2002-10-03 12:55 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021003184041.A29041@se1.cogenit.fr \
--to=romieu@cogenit.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®