From: Robert Varga <nite@hq.alert.sk>
To: Mark Peloquin <peloquin@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Evms-devel] Re: [PATCH] EVMS core 2/4: evms.h
Date: Fri, 4 Oct 2002 14:28:17 +0200 [thread overview]
Message-ID: <20021004122817.GA30205@hq.alert.sk> (raw)
In-Reply-To: <OF6E4A0115.7A4BB6D7-ON85256C47.0059EE6F@pok.ibm.com>
On Thu, Oct 03, 2002 at 12:42:23PM -0500, Mark Peloquin wrote:
> >> +static inline int
> >> +list_member(struct list_head *member)
> >> +{
> >> + return ((!member->next || !member->prev) ? FALSE : TRUE);
> >> +}
>
> > This should go into list.h
>
> Yes it should. I will pull this out of this header
> and submit a patch for list.h.
Possibly shortened to:
static inline int list_member(struct list_head *member)
{
return member->next && member->prev;
}
Faster, and (at least to me) it looks more obvious.
--
Kind regards,
Robert Varga
------------------------------------------------------------------------------
n@hq.sk http://hq.sk/~nite/gpgkey.txt
next prev parent reply other threads:[~2002-10-04 12:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-03 17:42 Mark Peloquin
2002-10-04 12:28 ` Robert Varga [this message]
2002-10-04 14:08 ` Christoph Hellwig
2002-10-04 14:36 ` Richard B. Johnson
-- strict thread matches above, loose matches on Subject: below --
2002-10-04 18:45 Steve Pratt
2002-10-07 17:25 ` Christoph Hellwig
2002-10-04 14:59 Mark Peloquin
2002-10-04 13:59 Mark Peloquin
2002-10-03 18:59 Mark Peloquin
2002-10-04 14:14 ` Christoph Hellwig
2002-10-04 14:34 ` Andreas Dilger
2002-10-04 17:10 ` Christoph Hellwig
2002-10-03 12:36 Kevin Corry
2002-10-03 14:50 ` Christoph Hellwig
2002-10-03 15:10 ` [Evms-devel] " Michael Clark
2002-10-03 15:14 ` Christoph Hellwig
2002-10-03 16:22 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021004122817.GA30205@hq.alert.sk \
--to=nite@hq.alert.sk \
--cc=linux-kernel@vger.kernel.org \
--cc=peloquin@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®