mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@debian.org>
To: Mark Peloquin <peloquin@us.ibm.com>
Cc: Matthew Wilcox <willy@debian.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add safe version of list_for_each_entry() to list.h
Date: Fri, 4 Oct 2002 17:00:21 +0100	[thread overview]
Message-ID: <20021004170021.F18545@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <OFDA00C8D3.E99FDDA0-ON85256C48.005322C4@pok.ibm.com>; from peloquin@us.ibm.com on Fri, Oct 04, 2002 at 10:48:33AM -0500

On Fri, Oct 04, 2002 at 10:48:33AM -0500, Mark Peloquin wrote:
> list_empty() can be used on check list heads *or*
> to check if a list element is currently in a list,
> assuming the coder uses list_del_init(). However,
> if the coder chooses to use list_del() [which sets
> the prev and next fields to 0] instead, there is no
> corresponding function to indicate if that element
> is currently on a list. This function does that.

That behaviour for list_del is new and, IMNSHO, bogus.  There's now _zero_
gain in using list_del instead of list_del_init.  akpm changed it about
5 months ago with a comment that says:

"list_head debugging"

so i think it's pretty safe to assume that this behaviour will not
remain into 2.6.  if you think you want list_member, use list_del_init
and list_empty() instead.

-- 
Revolutions do not require corporate support.

  reply	other threads:[~2002-10-04 15:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-04 15:48 Mark Peloquin
2002-10-04 16:00 ` Matthew Wilcox [this message]
2002-10-04 16:33   ` Andrew Morton
  -- strict thread matches above, loose matches on Subject: below --
2002-10-04 16:40 Mark Peloquin
2002-10-04 15:05 Matthew Wilcox
2002-10-03 23:42 Mark Peloquin
2002-10-03 23:44 ` Greg KH
2002-10-04  0:25   ` Kevin Corry
2002-10-04 13:58     ` Christoph Hellwig
2002-10-04 13:48       ` Kevin Corry
2002-10-04 13:51       ` Kevin Corry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021004170021.F18545@parcelfarce.linux.theplanet.co.uk \
    --to=willy@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peloquin@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®