mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [BK PATCH] pcibios_* removals for 2.5.40
Date: Fri, 4 Oct 2002 14:53:51 -0700	[thread overview]
Message-ID: <20021004215350.GB8843@kroah.com> (raw)
In-Reply-To: <3D9E0AB7.8090905@pobox.com>

On Fri, Oct 04, 2002 at 05:40:07PM -0400, Jeff Garzik wrote:
> >diff -Nru a/drivers/char/rocket.c b/drivers/char/rocket.c
> >--- a/drivers/char/rocket.c	Fri Oct  4 13:47:29 2002
> >+++ b/drivers/char/rocket.c	Fri Oct  4 13:47:29 2002
> >@@ -1993,7 +1993,7 @@
> > 			isa_boards_found++;
> > 	}
> > #ifdef CONFIG_PCI
> >-	if (pcibios_present()) {
> >+	if (pci_present()) {
> > 		if(isa_boards_found < NUM_BOARDS)
> > 			pci_boards_found = init_PCI(isa_boards_found);
> > 	} else {
> 
> can be greatly simplified -- just simply all the code in the ifdef to 
> "if (isa_boards_found...) ...init_PCI..."

Heh, again, this driver needs some major work in regards to PCI
cleanups, it's quite old.  It can probably be converted over to use the
drivers/serial core too.

thanks,

greg k-h

  reply	other threads:[~2002-10-04 21:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-03 22:40 Greg KH
2002-10-03 22:40 ` Greg KH
2002-10-03 22:41   ` Greg KH
2002-10-03 22:41     ` Greg KH
2002-10-04 16:33 ` Linus Torvalds
2002-10-04 16:53   ` Alan Cox
2002-10-04 17:30     ` Linus Torvalds
2002-10-04 18:01       ` Greg KH
2002-10-04 16:59   ` Greg KH
2002-10-04 17:28     ` Alan Cox
2002-10-04 18:07       ` Arnaldo Carvalho de Melo
2002-10-04 20:51     ` Greg KH
2002-10-04 20:52       ` Greg KH
2002-10-04 20:53         ` Greg KH
2002-10-04 20:54           ` Greg KH
2002-10-04 21:34             ` Jeff Garzik
2002-10-04 21:52               ` Greg KH
2002-10-04 21:36           ` Jeff Garzik
2002-10-04 21:40         ` Jeff Garzik
2002-10-04 21:53           ` Greg KH [this message]
2002-10-04 22:14             ` Russell King
2002-10-04 18:03   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021004215350.GB8843@kroah.com \
    --to=greg@kroah.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®