From: Anton Blanchard <anton@samba.org>
To: Steven French <sfrench@us.ibm.com>
Cc: Reuben Farrelly <reuben-linux@reub.net>, linux-kernel@vger.kernel.org
Subject: Re: "duplicate const" compile warning in 2.5.42
Date: Sat, 12 Oct 2002 21:52:57 +1000 [thread overview]
Message-ID: <20021012115257.GA15387@krispykreme> (raw)
In-Reply-To: <OF38E5DBB6.1DFD70C1-ON87256C50.002E73F2@boulder.ibm.com>
> Reuben,
> The "duplicate const" compile warning you mention seems to be a minor
> problem with the min/max macros.
>
> The fix for the 64 bit warnings for the cifs vfs are not going to affect
> the duplicate const minor warning caused by the min/max macro. This
> warning does not show up on my i386 2.5.41 builds.
Im using gcc 3.2 for ppc64 compiles, I guess earlier compilers dont
emit this warning.
Its not Steve's fault, for example mm/vmscan.c:shrink_caches gets
a warning because of
const int nr_pages:
...
to_reclaim = max(to_reclaim, nr_pages);
ie:
to_reclaim = ({
const typeof(to_reclaim) _x = (to_reclaim);
const typeof(nr_pages) _y = (nr_pages);
(void) (&_x == &_y);
_x > _y ? _x : _y;
});
Which ends up as const const int _y = (nr_pages);
Anton
prev parent reply other threads:[~2002-10-12 11:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-12 8:38 Steven French
2002-10-12 11:52 ` Anton Blanchard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021012115257.GA15387@krispykreme \
--to=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reuben-linux@reub.net \
--cc=sfrench@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®