From: "Adam J. Richter" <adam@yggdrasil.com>
To: eblade@blackmagik.dynup.net
Cc: linux-kernel@vger.kernel.org
Subject: Re: Patch: linux-2.5.42/kernel/sys.c - warm reboot should not suspend device
Date: Sun, 13 Oct 2002 13:44:01 -0700 [thread overview]
Message-ID: <200210132044.NAA02608@baldur.yggdrasil.com> (raw)
Eric Blade wrote:
>On Sun, 2002-10-13 at 15:24, Adam J. Richter wrote:
>> [...] I think the new behavior in IDE
>> of spinning down the hard drives on suspend is correct. The problem
>> is that the warm reboot system call is trying to suspend all of the
>> devices before a warm reboot for no reason. [...]
>Adam,
> I'm not sure the proper thing to do is necessarily remove the
>device_shutdown() call.
If, by this, you are saying that you have in mind some reason
why this should not be done, then please explain.
> Please try this patch [...]
Your patch does not apply and I don't see how renaming
a constant in essentially every place that it is referenced would
change the behavior of the code in a way releveant to the problem
that I described.
I don't see a problem with device_shutdown spinning down the
IDE hard disks. What I have a problem with, and what my patch fixes,
is the relatively new behavior of the warm reboot system call calling
device_shutdown. Why was this added? The reboot notifier chain is
already called for devices that need some preparation before it is
safe to reboot or halt.
Adam J. Richter __ ______________ 575 Oroville Road
adam@yggdrasil.com \ / Milpitas, California 95035
+1 408 309-6081 | g g d r a s i l United States of America
"Free Software For The Rest Of Us."
next reply other threads:[~2002-10-13 20:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-13 20:44 Adam J. Richter [this message]
2002-10-13 21:56 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200210132044.NAA02608@baldur.yggdrasil.com \
--to=adam@yggdrasil.com \
--cc=eblade@blackmagik.dynup.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®